[rfc] Add image preview functionality #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a tooltip-like component for previewing images in GraphQL responses. The ImagePreview component tries to detect if a string is an image URL and, if so, renders the image plus some metadata (dimensions and mime type). I found that if you specify a ResultsTooltip on the ResultViewer, it unconditionally renders no matter what. So I added a hacky way to prevent that from happening (the static shouldRender function). I don't really like this, but I don't see an obvious workaround without introducing a new codemirror addon.
dunnbobcat
commented
Apr 18, 2019
| @@ -26,16 +26,16 @@ const TestEnum = new GraphQLEnumType({ | |||
| values: { | |||
| RED: { description: 'A rosy color' }, | |||
| GREEN: { description: 'The color of martians and slime' }, | |||
| BLUE: { description: 'A feeling you might have if you can\'t use GraphQL' }, | |||
| } | |||
| BLUE: { description: "A feeling you might have if you can't use GraphQL" }, | |||
There was a problem hiding this comment.
Not sure why all these formatting changes got pulled in…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a tooltip-like component for previewing images in GraphQL
responses. The
ImagePreviewcomponent tries to detect if a string is animage URL and, if so, renders the image plus some metadata (dimensions
and mime type).
I found that if you specify a
ResultsTooltipon theResultViewer, itunconditionally renders no matter what. So I added a hacky way to
prevent that from happening (the static
shouldRenderfunction). I don'treally like this, but I don't see an obvious workaround without
introducing a new codemirror addon.
To test this, I added an image asset (the GraphQL logo in SVG) and hard-
coded it in the schema as
test.image. Then I fired up GraphiQL andmoused over the image URL in the results panel.