Remove usage of Flow placeholder argument + cleanup #1669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjmahone
reviewed
Jan 16, 2019
| deprecationReason: getDeprecationReason(field), | ||
| astNode: field, | ||
| }; | ||
| } | ||
|
|
||
| buildInputField(value: InputValueDefinitionNode): GraphQLInputField { | ||
| buildArg(value: InputValueDefinitionNode): GraphQLArgumentConfig { |
There was a problem hiding this comment.
We probably shouldn't expose this, as we're not building a schema GraphQLArgument but just a GraphQLArgumentConfig.
Having buildFoo sometimes return a GraphQLFoo and sometimes a GraphQLFooConfig is confusing.
There was a problem hiding this comment.
Oh I see we're already doing this with buildField. That is quite confusing but is fine then. I wish buildDirective was also building a GraphQLDirectiveConfig too, but that ship has sailed. Maybe a wishlist for v15?
There was a problem hiding this comment.
@mjmahone The entire class is internal it's just a bunch of functions that buildSchema/extendSchema are using.
So it's just cleanup of internal API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.