Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation: Remove internal functions for error messages #2159

Merged
merged 1 commit into from
Sep 10, 2019

Conversation

IvanGoncharov
Copy link
Member

@IvanGoncharov IvanGoncharov commented Sep 10, 2019

Makes it easier to review changes in error messages and in general validation tests more readable.
Also makes it's easier to maintain Flow typings after TS conversion.

@IvanGoncharov IvanGoncharov added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Sep 10, 2019
@IvanGoncharov IvanGoncharov changed the title validation: Remove internal functions for error messages Validation: Remove internal functions for error messages Sep 10, 2019
@IvanGoncharov IvanGoncharov merged commit 682fd4e into graphql:15.x.x Sep 10, 2019
@IvanGoncharov IvanGoncharov deleted the 15.x.x branch September 10, 2019 19:24
@IvanGoncharov IvanGoncharov restored the 15.x.x branch September 10, 2019 19:25
IvanGoncharov added a commit that referenced this pull request Sep 14, 2019
Makes it easier to review changes in error messages and in general validation tests more readable.
Also makes it easier to maintain Flow typings after TS conversion.
IvanGoncharov added a commit that referenced this pull request Sep 15, 2019
Makes it easier to review changes in error messages and in general validation tests more readable.
Also makes it easier to maintain Flow typings after TS conversion.
IvanGoncharov added a commit that referenced this pull request Sep 15, 2019
Makes it easier to review changes in error messages and in general validation tests more readable.
Also makes it easier to maintain Flow typings after TS conversion.
Cito added a commit to Cito/graphql-js that referenced this pull request Dec 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: polish 💅 PR doesn't change public API or any observed behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant