Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the error message for unknown field #261

Merged
merged 1 commit into from
Feb 2, 2016

Conversation

fson
Copy link
Contributor

@fson fson commented Dec 7, 2015

The error message for unknown field was literal:
"In field "${providedField}": Unknown field."

Add necessary back ticks to the template literal so the message
includes the actual field name. Also change the test that claims to
test this case to actually test it.

The error message for unknown field was literal:
"In field "${providedField}": Unknown field."

Add necessary back ticks to the template literal so the message
includes the actual field name. Also change the test that claims to
test this case to actually test it.
@freiksenet
Copy link
Contributor

Ship.

On Mon, Dec 7, 2015 at 4:00 PM, Ville Immonen notifications@github.com
wrote:

The error message for unknown field was literal:
"In field "${providedField}": Unknown field."
Add necessary back ticks to the template literal so the message
includes the actual field name. Also change the test that claims to
test this case to actually test it.
You can view, comment on, or merge this pull request online at:
#261
-- Commit Summary --

@freiksenet
Copy link
Contributor

Hahaha! :) Thought it's a PR in our internal repo :D Sorry :)

On Mon, Dec 7, 2015 at 4:01 PM, null freiksenet@gmail.com wrote:

Ship.
On Mon, Dec 7, 2015 at 4:00 PM, Ville Immonen notifications@github.com
wrote:

The error message for unknown field was literal:
"In field "${providedField}": Unknown field."
Add necessary back ticks to the template literal so the message
includes the actual field name. Also change the test that claims to
test this case to actually test it.
You can view, comment on, or merge this pull request online at:
#261
-- Commit Summary --

@aweary
Copy link

aweary commented Jan 31, 2016

@leebyron is this going to be merged at some point? We're seeing this issue as well.

@leebyron leebyron merged commit 20694e4 into graphql:master Feb 2, 2016
@leebyron
Copy link
Contributor

leebyron commented Feb 2, 2016

Nice find and fix! #clowntown

@fson fson deleted the fix-unknown-field-error branch February 2, 2016 12:12
freiksenet added a commit to reindexio/reindex-api that referenced this pull request Mar 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants