Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to pass generics to DocumentNode to allow TS type inference by GraphQL clients #2728

Closed
wants to merge 2 commits into from
Closed

Allow to pass generics to DocumentNode to allow TS type inference by GraphQL clients #2728

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d96bea
reduce changes to minimum
dotansimha Aug 16, 2020
c46ab73
added comments
dotansimha Aug 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/language/ast.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,14 @@ export interface NameNode {

// Document

export interface DocumentNode {
export interface DocumentNode<
TData = Record<string, any>,
TVariables = Record<string, any>
> {
// __resultType and __variablesType are unused, and defined only to enforce TS structural
// types and make sure they are not being stripped.
readonly __resultType?: TData;
readonly __variablesType?: TVariables;
readonly kind: 'Document';
readonly loc?: Location;
readonly definitions: ReadonlyArray<DefinitionNode>;
Expand Down