Add GraphQLSchema types field #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leebyron
force-pushed
the
tgriesser-schema-types
branch
from
4adc6a9
to
f3c80d8
Compare
leebyron
force-pushed
the
tgriesser-schema-types
branch
from
f3c80d8
to
2330fef
Compare
leebyron
force-pushed
the
tgriesser-schema-types
branch
from
2330fef
to
be3ee64
Compare
leebyron
force-pushed
the
tgriesser-schema-types
branch
from
be3ee64
to
5621af2
Compare
leebyron
force-pushed
the
tgriesser-schema-types
branch
from
5621af2
to
857339a
Compare
This is a rebased and updated version of @tgriesser's #199. I further extended it to completely remove the side-effectful mutation of Interface types rather than just deferring that mutation to schema creation time. This introduces a *breaking* change to the Type System API. Now, any individual Interface type does not have the required information to answer `getPossibleTypes` or `isPossibleType` without knowing the other types in the Schema. These methods were moved to the Schema API, accepting the abstract type as the first parameter. This also introduces a *breaking* change to the type comparator functions: `isTypeSubTypeOf` and `doTypesOverlap` which now require a Schema as a first argument.
leebyron
force-pushed
the
tgriesser-schema-types
branch
from
857339a
to
6a1f23e
Compare
|
Changes Unknown when pulling 6a1f23e on tgriesser-schema-types into * on master*. |
Closed
This was referenced Apr 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased and updated version of @tgriesser's #199. I further extended it to completely remove the side-effectful mutation of Interface types rather than just deferring that mutation to schema creation time.
This introduces a breaking change to the Type System API. Now, any individual Interface type does not have the required information to answer
getPossibleTypesorisPossibleTypewithout knowing the other types in the Schema. These methods were moved to the Schema API, accepting the abstract type as the first parameter.This also introduces a breaking change to the type comparator functions:
isTypeSubTypeOfanddoTypesOverlapwhich now require a Schema as a first argument.