refactor(InterfaceType) determine possible_types based on the schema #142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking a cue from graphql/graphql-js#327
Previously,
InterfaceType#possible_types
was implemented as an array which was mutated for every object that implemented it. This caused bugs and resulted in complex gem code.So instead, determine possible types within the schema. This will fix some nasty bugs, support Rails development better, and remove the lingering caveat when people ask "can you make multiple schemas".
The downer is that it's a breaking change: any orphan type must be passed to
types:
(where previously it was discovered at load-time).Before shipping this change, I'll push a minor version with deprecation warnings.