Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove subscriptions from allowed POST operations #166

Merged
merged 1 commit into from
Nov 26, 2021

Conversation

n1ru4l
Copy link
Contributor

@n1ru4l n1ru4l commented Nov 19, 2021

When executing a subscription operation a client expects multiple results which can best be expressed as a stream, while the incremental delivery RFC could be misused for describing how a stream of subscription events can be delivered to clients, it is clearly not the correct fit, as multipart requests are intended to be short-lived, while subscriptions could stay active for longer periods of time. Until alternative directions such as SSE events (as supported via graphql-helix and graphql-sse) are explored it might make sense to completely remove subscriptions from the list of allowed operations that can be executed via POST.

Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. Further many servers when you POST a subscribe operation will execute it rather than subscribe, and that rarely makes sense to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants