Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify URL requirements #94

Merged
merged 6 commits into from Jun 30, 2020
Merged

Clarify URL requirements #94

merged 6 commits into from Jun 30, 2020

Conversation

spawnia
Copy link
Member

@spawnia spawnia commented Apr 30, 2020

Relates to the discussion in #91

@ghmcadams @ralfhandl

README.md Outdated Show resolved Hide resolved
@spawnia spawnia mentioned this pull request Apr 30, 2020
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@spawnia
Copy link
Member Author

spawnia commented May 1, 2020

Thanks for your suggestions so far. I expanded the text to be more explicit about the aspects you mentioned.

While i do think the spec should be precise, i would rather explain things a bit more in depth than to aim for maximum conciseness.

Copy link
Contributor

@ralfhandl ralfhandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new wording!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
spawnia and others added 2 commits May 6, 2020 21:48
Co-authored-by: Gabriel McAdams <ghmcadams@users.noreply.github.com>
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated
at this URL. Other protocols may also use that URL.
A GraphQL over HTTP compliant server MUST designate at least one URL that handles GraphQL requests.

All GraphQL operations that are available in a schema MUST be available on all URLs that are designated to it.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
All GraphQL operations that are available in a schema MUST be available on all URLs that are designated to it.
All Queries and Mutations that are available in a schema MUST be available on all URLs that are designated to it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about subscriptions?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subscriptions often have some kind of redirection going on where multiple servers are involved. We might specify that in the future, but don't have a clear answer now.

@sjparsons sjparsons mentioned this pull request May 26, 2020
12 tasks
- No promises on subscriptions for now
- Introspection determines the schema
@spawnia
Copy link
Member Author

spawnia commented Jun 15, 2020

I incorporated feedback from the comments and the last working group meeting. If there is nothing seriously wrong, we can merge this for now to allow fine-grained iteration later.

@sjparsons sjparsons merged commit 6d8d585 into graphql:master Jun 30, 2020
@sjparsons
Copy link
Collaborator

I figured we can just merge for now and take any future modifications in a future PR.

@spawnia spawnia deleted the clarify-url-spec branch June 30, 2020 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants