New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify URL requirements #94
Conversation
Thanks for your suggestions so far. I expanded the text to be more explicit about the aspects you mentioned. While i do think the spec should be precise, i would rather explain things a bit more in depth than to aim for maximum conciseness. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the new wording!
Co-authored-by: Gabriel McAdams <ghmcadams@users.noreply.github.com>
README.md
Outdated
at this URL. Other protocols may also use that URL. | ||
A GraphQL over HTTP compliant server MUST designate at least one URL that handles GraphQL requests. | ||
|
||
All GraphQL operations that are available in a schema MUST be available on all URLs that are designated to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All GraphQL operations that are available in a schema MUST be available on all URLs that are designated to it. | |
All Queries and Mutations that are available in a schema MUST be available on all URLs that are designated to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about subscriptions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Subscriptions often have some kind of redirection going on where multiple servers are involved. We might specify that in the future, but don't have a clear answer now.
- No promises on subscriptions for now - Introspection determines the schema
I incorporated feedback from the comments and the last working group meeting. If there is nothing seriously wrong, we can merge this for now to allow fine-grained iteration later. |
I figured we can just merge for now and take any future modifications in a future PR. |
Relates to the discussion in #91
@ghmcadams @ralfhandl