Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove graphql-confing #874

Merged
merged 1 commit into from
Nov 13, 2018
Merged

Remove graphql-confing #874

merged 1 commit into from
Nov 13, 2018

Conversation

huv1k
Copy link
Collaborator

@huv1k huv1k commented Oct 28, 2018

Remove config dependency to reduce size of html package

@huv1k huv1k merged commit ec1ff64 into master Nov 13, 2018
@huv1k huv1k deleted the remove-config branch November 13, 2018 16:06
abernix added a commit to apollographql/apollo-server that referenced this pull request Nov 28, 2018
@abernix
Update @apollographql/graphql-playground-html to latest version.
adb3f1c 
With any luck, we will no longer necessitate our fork which removed the
`graphql-config` dependency thanks to the work done in:

graphql/graphql-playground#874

🎉

Most notably though, this fixes a documentation scrolling problem with
Safari.
@abernix abernix mentioned this pull request Nov 28, 2018
Merged
abernix added a commit to apollographql/apollo-server that referenced this pull request Nov 28, 2018
@abernix
Update @apollographql/graphql-playground-html to latest version. (#…
fedc96d 
…2037)

With any luck, we will no longer necessitate our fork which removed the
`graphql-config` dependency thanks to the work done in:

graphql/graphql-playground#874

🎉

Most notably though, this fixes a documentation scrolling problem with
Safari.
@blakeembrey
Copy link

@HuVik Did this make a difference? Type-only imports shouldn't be emitted into the JavaScript, therefore not included in the bundle anyway.

@huv1k
Copy link
Collaborator Author

huv1k commented Feb 15, 2019

I don't recall, but apollo guys had a problem with graphql-confing being part of html package. So we removed it, maybe I am going to investigate more and see what was happening. We wanted to push changes ASAP, so there was not enough testing. Do you have a problem with types? Or what brought you here after such a long time?

@blakeembrey
Copy link

blakeembrey commented Feb 15, 2019 •
edited
Loading

@HuVik No issue actually 😄 I was just browsing issues related to graphql versions and saw this, was curious about the issue since it's something that shouldn't happen with TypeScript type-only imports.

Edit: Of course, I'm always curious to know the issue if someone made something less type-safe to try and fix some other issue. It would mean a deeper problem with TypeScript, so wanted to check.

cgxxv pushed a commit to cgxxv/graphql-playground that referenced this pull request Mar 25, 2022
@huv1k
Remove graphql-confing (graphql#874)
9cab497
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@huv1k @blakeembrey