Require Interface to implement at least 1 Object #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matching PR for graphql-js: graphql/graphql-js#1280
3 tasks
|
Thanks for accounting for this schema validation addition! |
|
I think we should change the spec and revert this changes: there is no reason a schema should be required to have objects implementing each interface. A very common pattern is to create an interface first, start programming against that, then weeks later actually implement that interface. This is also a really nasty breaking change for large, existing schemas. |
mjmahone
added a commit
to graphql/graphql-js
that referenced
this pull request
Jun 8, 2018
It is unclear whether the spec validation from graphql/graphql-spec#424 as implemented by #1277 is what we want to have for the GraphQL Schema long term. This RFC lets us explore that option more, to see whether the breaking schema change is the right path forward.
mjmahone
added a commit
that referenced
this pull request
Jun 8, 2018
Re-applies #424, but as an RFC. This change is a major spec breaking change, and if it is desireable, we should provide an upgrade path for existing schemas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matches graphql-js PR: graphql/graphql-js#1280
For background, see graphql/graphql-js#1277