Prettier pre-work: formatting tweaks #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've reviewed these changes and I'm happy they are all deliberate. |
benjie
force-pushed
the
pre-prettier-tweaks
branch
from
05ad20b
to
746790c
Compare
|
I've rebased this on |
leebyron
reviewed
Apr 5, 2021
spec/Section 5 -- Validation.md
Outdated
| @@ -1494,7 +1500,7 @@ For example, the following query will not pass validation because `@skip` has | |||
| been used twice for the same field: | |||
|
|
|||
| ```graphql counter-example | |||
| query ($foo: Boolean = true, $bar: Boolean = false) { | |||
| query($foo: Boolean = true, $bar: Boolean = false) { | |||
There was a problem hiding this comment.
This is a prettier bug. Just filed prettier/prettier#10655
leebyron
added
the
✏️ Editorial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #727 I have been working on
prettiersupport for formatting the GraphQL spec. The PR is formed of three commits: one manually applying changes to the markdown to minimize the resulting diff, one adding the prettier tooling, and finally one that runsprettieragainst the codebase.When the following three PRs to spec-md are merged and released, the diff of the generated HTML on that final commit will be very small (mostly whitespace within tables due to the new table formatting):Allow for escaped * in quantifiers leebyron/spec-md#53Allow newline after "one of" leebyron/spec-md#54Unescape dollars in text leebyron/spec-md#55(and optionally Trim table cells leebyron/spec-md#56)(Edit: all these have been merged and Lee's advanced spec-md further 🙌 this means that final diff is now EMPTY!)
This PR is the first commit from #727: the manual formatting changes that were required. My hope is that we can merge this now and then reviewing the prettier formatted PR will be significantly less work (because the output HTML will be identical).
The changes in this PR are broadly:
raw(support added in spec-md)Marking this as draft because I want to validate my changes before others spend time looking at it.