October2021 Edition & Changelog #871
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leebyron
force-pushed
the
may-2021-release-candidate
branch
from
32ef0ab
to
fd8f485
Compare
leebyron
force-pushed
the
may-2021-release-candidate
branch
from
fd8f485
to
dd14865
Compare
benjie
approved these changes
May 27, 2021
changelogs/May2021.md
Outdated
| [Brian Warner]: https://github.com/brianwarner | ||
| [Chris Brown]: https://github.com/ccbrown | ||
| [David Glasser]: https://github.com/glasser | ||
| [dugenkui]: https://github.com/graphql/dugenkui03 |
There was a problem hiding this comment.
Suggested change
| [dugenkui]: https://github.com/graphql/dugenkui03 | |
| [dugenkui]: https://github.com/dugenkui03 |
changelogs/May2021.md
Outdated
Comment on lines
290
to
294
| +[Joint Development Foundation](https://www.jointdevelopment.org/). The current | ||
| +[Working Group](https://github.com/graphql/graphql-wg) charter, which includes | ||
| +the IP policy governing all working group deliverables (including specifications, | ||
| +source code, and datasets) may be found at | ||
| +[https://technical-charter.graphql.org](https://technical-charter.graphql.org). |
There was a problem hiding this comment.
Sentence should make sense with parenthesis removed, but a missing comma means this doesn't fully make sense:
The current Working Group charter, which includes the IP policy governing all working group deliverables may be found at https://technical-charter.graphql.org.
Suggested change
| +[Joint Development Foundation](https://www.jointdevelopment.org/). The current | |
| +[Working Group](https://github.com/graphql/graphql-wg) charter, which includes | |
| +the IP policy governing all working group deliverables (including specifications, | |
| +source code, and datasets) may be found at | |
| +[https://technical-charter.graphql.org](https://technical-charter.graphql.org). | |
| +[Joint Development Foundation](https://www.jointdevelopment.org/). The current | |
| +[Working Group](https://github.com/graphql/graphql-wg) charter, which includes | |
| +the IP policy governing all working group deliverables (including specifications, | |
| +source code, and datasets), may be found at | |
| +[https://technical-charter.graphql.org](https://technical-charter.graphql.org). |
leebyron
force-pushed
the
may-2021-release-candidate
branch
from
dd14865
to
de24777
Compare
robzhu
reviewed
Jun 21, 2021
changelogs/May2021.md
Outdated
| with the algorithms to power them. The goal of this specification is to provide | ||
| a foundation and framework for an ecosystem of GraphQL tools, client libraries, | ||
| -and server implementations -- spanning both organizations and platforms -- that | ||
| +and service implementations—spanning both organizations and platforms—that |
There was a problem hiding this comment.
the new version of this line was hard to read, could we omit "spanning both organizations and platforms"?
nyteshade
approved these changes
Jul 12, 2021
leebyron
force-pushed
the
may-2021-release-candidate
branch
from
de24777
to
cf8a1c8
Compare
|
✔️ Deploy Preview for graphql-spec-draft ready! 🔨 Explore the source changes: cf8a1c8 🔍 Inspect the deploy log: https://app.netlify.com/sites/graphql-spec-draft/deploys/61784d58ad9e3b0007136def 😎 Browse the preview: https://deploy-preview-871--graphql-spec-draft.netlify.app |
|
Whoops, sorry for the inadvertent close. Trying to incorporate final feedback before merging this, and messed up the branch 🤦. I'll get this fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@graphql/tsc, please find here the changelog and release candidate for the May2021 edition of the spec:
With the changelog available, we'll open the review and voting process. Once approved, this PR will be merged and the next edition will be live.
The text is not perfect and there are ongoing editorial changes as well as RFCs to further improve it in future editions. If when reviewing you spot something that could be improved, please feel free to drop a review comment on the "diff" section of the changelog within this PR. I'll assume all review comments are "forward looking" to describe future improvements. If you have a concern that will block you from voting to approve this edition please say so explicitly.
Closes #855