Fix mem leak when failure is set #63
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
GraphQLParser.cpp
Outdated
| yy::GraphQLParserImpl parser(enableSchema, &outAST, outError, scanner); | ||
| int failure = parser.parse(); | ||
| if (failure && outAST) |
There was a problem hiding this comment.
Please always use braces around if statements. It's too easy to make mistakes otherwise.
I wouldn't normally request changes over this, but while I'm here: delete nullptr is safe, no need to test outAST.
|
Looks good to me! Can you fold the second commit into the first one to keep the history clean, please? Happy to merge after that's done. |
|
Thanks for taking time to review. I have tried to merge two checkins into one. |
Fix for #62