Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve offline behavior to avoid losing PWA support in upcoming Chrome #86

Closed
grarer opened this issue Mar 17, 2021 · 1 comment
Closed
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@grarer
Copy link
Owner

grarer commented Mar 17, 2021

Chrome shows this warning in the browser console:

Site cannot be installed: Page does not work offline. Starting in Chrome 93, the installability criteria is changing, and this site will not be installable. See https://goo.gle/improved-pwa-offline-detection for more information.

Chrome 93 doesn't release until this fall, so it doesn't really affect this as a class project, but it's a good idea to resolve this if it wouldn't be too much effort.

@grarer grarer added bug Something isn't working wontfix This will not be worked on labels Mar 17, 2021
@grarer
Copy link
Owner Author

grarer commented Mar 22, 2021

if this were a real company, we would probably fix this bug over the summer to have everything ready in time for the new chrome release in the fall. since this project will be over by then, we don't need to fix this right now.

@grarer grarer closed this as completed Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant