Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe we should use $PATH here as default? #19

Closed
OskarStark opened this issue Sep 5, 2014 · 2 comments
Closed

Maybe we should use $PATH here as default? #19

OskarStark opened this issue Sep 5, 2014 · 2 comments

Comments

@OskarStark
Copy link
Contributor

https://github.com/graste/environaut/blob/master/src/Environaut/Checks/ExecutableCheck.php#L83

A benefit would be to have the correct order of the directories, the system would use....
bildschirmfoto 2014-09-05 um 15 31 50

@DracoBlue
Copy link
Collaborator

+1

Maybe a simple "which executable" instead?

@graste
Copy link
Owner

graste commented Oct 6, 2014

You mean like it is already done in line 153? Other than that I think the idea of using the $PATH to set the default choices in order to get some good lookup folders is not bad. The used defaults are ones that are often used though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants