Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

Fix bitcoin address styling #2065

Closed
patcon opened this issue Feb 20, 2014 · 7 comments
Closed

Fix bitcoin address styling #2065

patcon opened this issue Feb 20, 2014 · 7 comments

Comments

@patcon
Copy link
Contributor

patcon commented Feb 20, 2014

Defect introduced by #2053

image

Summary

Stylying when adding/editing a bitcoin address is wonky and inconsistent. AJAX creates old styling of accounts elsewhere, but refresh results in new styling with "Edit" button on the left.

Reproduce

  1. Create a user account.
  2. Go to profile page.
  3. Add a Bitcoin address. (example: 1KJD5M4TaHFGEWwMVcfhVd3J1ov52u5Zzc)
  4. Note styling bug.
  5. Refresh page, to fix styling.
  6. Clicked "Edit" beside the bitcoin address, and then "Save"
  7. Note styling bug again.
@patcon patcon mentioned this issue Feb 20, 2014
@chadwhitacre
Copy link
Contributor

Since #2053 hasn't landed yet, should we discuss over there instead of opening a new ticket?

@patcon
Copy link
Contributor Author

patcon commented Feb 20, 2014

I'm down. It just seemed minor in the big scheme and I didn't want to clutter up the issue with non-blockers. But I'll bring it back in :)

@patcon
Copy link
Contributor Author

patcon commented Feb 20, 2014

Do markdown checkout subtasks like this work? #2053 (comment)
(backref above says 1 tasks (0 completed, 1 remaining))

I believe that's one way how github recommends working -- one PR with code, and subtasks in connected issues. If not, I'm easy. The giant issue with everything in it is kinda intimidating though, to be honest

@kyungmin
Copy link

@patcon sorry, I'm still not clear on the issue. The following screens are what I'm seeing locally. Can you please elaborate?

screen shot 2014-02-20 at 12 19 21 pm
screen shot 2014-02-20 at 12 19 27 pm

@patcon
Copy link
Contributor Author

patcon commented Feb 22, 2014

It resurfaces during AJAX when you save either the first or subsequent times. So clicking "save" there should manifest it.

@kyungmin
Copy link

Got it, the last commit should fix this issue.

@patcon
Copy link
Contributor Author

patcon commented Feb 22, 2014

🎆

@patcon patcon closed this as completed Feb 22, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants