Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Kubernetes Websocket V5 protocol #15474

Closed
tigrato opened this issue Aug 12, 2022 · 4 comments
Closed

Support for Kubernetes Websocket V5 protocol #15474

tigrato opened this issue Aug 12, 2022 · 4 comments
Assignees
@AntonAM
Labels
c-am Internal Customer Reference feature-request Used for new features in Teleport, improvements to current should be #enhancements kubernetes kubernetes-access

Comments

@tigrato
Copy link
Contributor

tigrato commented Aug 12, 2022 •
edited
Loading

Kubernetes will deprecate the usage of SPDY for IO-related events (attach, exec, port-forward) and will introduce a new websocket protocol (V5).

Teleport must support it as a server and as client.

Draft PR: kubernetes/kubernetes#119157
RFD: kubernetes/enhancements#4016
@tigrato tigrato added feature-request Used for new features in Teleport, improvements to current should be #enhancements kubernetes-access kubernetes labels Aug 12, 2022
@tigrato
Copy link
Contributor Author

tigrato commented Aug 12, 2022

This is a tracking issue, for now no action is required since the PR is not yet ready/merged

This was referenced Aug 12, 2022
Closed
Merged
@ArunNadda ArunNadda added the c-am Internal Customer Reference label Aug 15, 2022
@ringerc
Copy link

ringerc commented Nov 25, 2022

If you're getting errors like

websocket._exceptions.WebSocketBadStatusException: Handshake status 500 Internal Server Error

During handling of the above exception, another exception occurred:

...

kubernetes.client.exceptions.ApiException: (0)
Reason: Handshake status 500 Internal Server Error

from the Python kubernetes client when (say) attempting to set up port-forwards, this will be why. Unfortunately the Python client doesn't detect when the kube API server endpoint doesn't support websockets and fail with a more graceful error.

@aviramha
Copy link

Is this still relevant?

@AntonAM
Copy link
Contributor

AntonAM commented Mar 29, 2024

Implemented by #39755

@AntonAM AntonAM closed this as completed Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AntonAM AntonAM

Labels
c-am Internal Customer Reference feature-request Used for new features in Teleport, improvements to current should be #enhancements kubernetes kubernetes-access
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ringerc @AntonAM @tigrato @ArunNadda @aviramha