Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KindWindowsDesktops to ListResources #10769

Merged
merged 8 commits into from
Mar 7, 2022
Merged

Add KindWindowsDesktops to ListResources #10769

merged 8 commits into from
Mar 7, 2022

Conversation

kimlisa
Copy link
Contributor

@kimlisa kimlisa commented Mar 3, 2022 •
edited
Loading

part of RFD 55

Description

To add support for type windows desktops to our generic ListResources, it needed it's own implementation ListWindowsDesktops in its own service layer (all other resources thus far belongs in the presence layer). This function is not made available to the client, they would need to use ListResources with type KindWindowsDesktop.

In addition adds support for sorting.

Required PR

@kimlisa kimlisa requested review from zmb3, espadolini and rosstimothy and removed request for alex-kovoy and gzdunek March 3, 2022 00:10
zmb3
zmb3 requested changes Mar 3, 2022
View reviewed changes
api/types/desktop.go Outdated Show resolved Hide resolved
api/types/desktop_test.go Outdated Show resolved Hide resolved
lib/auth/api.go Outdated Show resolved Hide resolved
lib/services/local/desktops_test.go Outdated Show resolved Hide resolved
espadolini
espadolini approved these changes Mar 3, 2022
View reviewed changes
Copy link
Contributor

@espadolini espadolini left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific reason why desktops are not part of Presence like the other things? Should they be?

@kimlisa
Copy link
Contributor Author

kimlisa commented Mar 3, 2022

@espadolini it was b/c KindWindowsDesktop is not a keep alive type of resource, it belonged in the services/local/desktop (versus KindDesktopWindowsService that does belong in services/local/presence). The desktop resource works a bit differently from others in that a service does not hold information of the desktops it proxies.

@kimlisa kimlisa requested a review from zmb3 March 3, 2022 17:39
@kimlisa kimlisa merged commit 632d851 into master Mar 7, 2022
@kimlisa kimlisa deleted the lisa/windows-desktops branch March 7, 2022 16:58
kimlisa added a commit that referenced this pull request Mar 7, 2022
@kimlisa
Add KindWindowsDesktops to ListResources (#10769)
212605b 
* Also add windows desktops sorter and its type converters
* Use forked vulcand/predicate library: allows traversing
  by embedded fields

Part of RFD 55
@kimlisa kimlisa mentioned this pull request Mar 7, 2022
Merged
kimlisa added a commit that referenced this pull request Mar 7, 2022
@kimlisa
Add KindWindowsDesktops to ListResources (#10769) (#10912)
dcfc9cc 
* Also add windows desktops sorter and its type converters
* Use forked vulcand/predicate library: allows traversing
  by embedded fields

Part of RFD 55
@webvictim webvictim mentioned this pull request Apr 19, 2022
Closed
@webvictim webvictim mentioned this pull request Jun 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@espadolini espadolini espadolini approved these changes

@zmb3 zmb3 zmb3 approved these changes

@rosstimothy rosstimothy rosstimothy approved these changes

Assignees
No one assigned
Labels
backport-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kimlisa @espadolini @zmb3 @rosstimothy