-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register cluster configuration service #38734
Conversation
bf3a686
to
eb111db
Compare
d670327
to
e69c42b
Compare
// An old server would send PIVSlot instead of HardwareKey.PIVSlot | ||
// TODO(Joerger): DELETE IN 17.0.0 | ||
pref.CheckSetPIVSlot() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just double-checking, this fallback is only needed for the old service?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah if the server is recent enough to have the new cluster config service then it also has to be setting HardwareKey.PIVSlot instead of PIVSlot.
Updates the auth gRPC server to include the new clusterconfigv1 service. The api client was also updated to allow interacting with the new service(cluster audit config not included yet). Nothing has yet been converted to use the new service, that will come in a follow up. The RPC service proto was also updated to fix a typo that was reverted in #38736.
90b4464
to
250f825
Compare
Updates the auth gRPC server to include the new clusterconfigv1 service. The api client was also updated to allow interacting with the new service(cluster audit config not included yet). Nothing has yet been converted to use the new service, that will come in a follow up. The RPC service proto was also updated to fix a typo that was reverted in #38736.
Updates the auth gRPC server to include the new clusterconfigv1 service. The api client was also updated to allow interacting with the new service(cluster audit config not included yet). Nothing has yet been converted to use the new service, that will come in a follow up. The RPC service proto was also updated to fix a typo that was reverted in #38736.
…ngConfig, SessionRecordingConfig (#39785) * Register cluster configuration service (#38734) Updates the auth gRPC server to include the new clusterconfigv1 service. The api client was also updated to allow interacting with the new service(cluster audit config not included yet). Nothing has yet been converted to use the new service, that will come in a follow up. The RPC service proto was also updated to fix a typo that was reverted in #38736. * Convert SetClusterNetworkingConfig usages to new Create/Update/Upsert API (#39219) Migrates callers off the deprecated API and onto the new API so that ClusterNetworkingConfig can be protected via optimistic locking when appropriate. * Convert SetAuthPreferences usages to new Create/Update/Upsert API (#38895) Migrates callers off the deprecated API and onto the new API so that AuthPreferences can be protected via optimistic locking when appropriate. * Convert SetSessionRecordingConfig usages to new Create/Update/Upsert API (#39249) Migrates callers off the deprecated API and onto the new API so that SessionRecordingConfig can be protected via optimistic locking when appropriate.
Updates the auth gRPC server to include the new clusterconfigv1 service. The api client was also updated to allow interacting with the new service(cluster audit config not included yet). Nothing has yet been converted to use the new service, that will come in a follow up.
The RPC service proto was also updated to fix a typo that was reverted in #38736.