[v15] Enforce optimistic locking for AuthPreferences, ClusterNetworkingConfig, SessionRecordingConfig #39785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
force-pushed
the
tross/backport-cluster-config-api/v15
branch
2 times, most recently
from
02b18bc
to
6fb0795
Compare
|
Will hold off merging this until 15.2 |
github-actions
bot
added
application-access
backport
database-access
Updates the auth gRPC server to include the new clusterconfigv1 service. The api client was also updated to allow interacting with the new service(cluster audit config not included yet). Nothing has yet been converted to use the new service, that will come in a follow up. The RPC service proto was also updated to fix a typo that was reverted in #38736.
… API (#39219) Migrates callers off the deprecated API and onto the new API so that ClusterNetworkingConfig can be protected via optimistic locking when appropriate.
…8895) Migrates callers off the deprecated API and onto the new API so that AuthPreferences can be protected via optimistic locking when appropriate.
…API (#39249) Migrates callers off the deprecated API and onto the new API so that SessionRecordingConfig can be protected via optimistic locking when appropriate.
rosstimothy
force-pushed
the
tross/backport-cluster-config-api/v15
branch
from
6fb0795
to
14e870a
Compare
|
PTAL @r0mant @gabrielcorado Also @r0mant could I please get a flaky test bypass? |
r0mant
approved these changes
Mar 27, 2024
|
/excludeflake * |
gabrielcorado
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports client side changes to enable optimistic locking to branch/v15
Changelog: Enforce optimistic locking for AuthPreferences, ClusterNetworkingConfig, SessionRecordingConfig