Remove ResetSessionRecordingConfig with incorrect return type #38736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cluster config RPC service had a typo in the return type of ResetSessionRecordingConfig. Since our proto linter doesn't allow renaming, this removes the RPC entirely so that it can be added with the correct signature in a follow up. This service was only recently introduced, and is not exposed in any way with the Auth grpc server so removal is a safe operation.
rosstimothy
added
the
no-changelog
espadolini
approved these changes
Feb 28, 2024
fspmarshall
approved these changes
Feb 28, 2024
public-teleport-github-review-bot
bot
removed request for
r0mant and
greedy52
rosstimothy
added a commit
that referenced
this pull request
Feb 28, 2024
Updates the auth gRPC server to include the new clusterconfigv1 service. The api client was also updated to allow interacting with the new service(cluster audit config not included yet). Nothing has yet been converted to use the new service, that will come in a follow up. The RPC service proto was also updated to fix a typo that was reverted in #38736.
rosstimothy
added a commit
that referenced
this pull request
Feb 28, 2024
Updates the auth gRPC server to include the new clusterconfigv1 service. The api client was also updated to allow interacting with the new service(cluster audit config not included yet). Nothing has yet been converted to use the new service, that will come in a follow up. The RPC service proto was also updated to fix a typo that was reverted in #38736.
rosstimothy
added a commit
that referenced
this pull request
Mar 1, 2024
Updates the auth gRPC server to include the new clusterconfigv1 service. The api client was also updated to allow interacting with the new service(cluster audit config not included yet). Nothing has yet been converted to use the new service, that will come in a follow up. The RPC service proto was also updated to fix a typo that was reverted in #38736.
rosstimothy
added a commit
that referenced
this pull request
Mar 1, 2024
Updates the auth gRPC server to include the new clusterconfigv1 service. The api client was also updated to allow interacting with the new service(cluster audit config not included yet). Nothing has yet been converted to use the new service, that will come in a follow up. The RPC service proto was also updated to fix a typo that was reverted in #38736.
rosstimothy
added a commit
that referenced
this pull request
Mar 5, 2024
Updates the auth gRPC server to include the new clusterconfigv1 service. The api client was also updated to allow interacting with the new service(cluster audit config not included yet). Nothing has yet been converted to use the new service, that will come in a follow up. The RPC service proto was also updated to fix a typo that was reverted in #38736.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 5, 2024
Updates the auth gRPC server to include the new clusterconfigv1 service. The api client was also updated to allow interacting with the new service(cluster audit config not included yet). Nothing has yet been converted to use the new service, that will come in a follow up. The RPC service proto was also updated to fix a typo that was reverted in #38736.
rosstimothy
added a commit
that referenced
this pull request
Mar 25, 2024
Updates the auth gRPC server to include the new clusterconfigv1 service. The api client was also updated to allow interacting with the new service(cluster audit config not included yet). Nothing has yet been converted to use the new service, that will come in a follow up. The RPC service proto was also updated to fix a typo that was reverted in #38736.
rosstimothy
added a commit
that referenced
this pull request
Mar 27, 2024
Updates the auth gRPC server to include the new clusterconfigv1 service. The api client was also updated to allow interacting with the new service(cluster audit config not included yet). Nothing has yet been converted to use the new service, that will come in a follow up. The RPC service proto was also updated to fix a typo that was reverted in #38736.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 27, 2024
…ngConfig, SessionRecordingConfig (#39785) * Register cluster configuration service (#38734) Updates the auth gRPC server to include the new clusterconfigv1 service. The api client was also updated to allow interacting with the new service(cluster audit config not included yet). Nothing has yet been converted to use the new service, that will come in a follow up. The RPC service proto was also updated to fix a typo that was reverted in #38736. * Convert SetClusterNetworkingConfig usages to new Create/Update/Upsert API (#39219) Migrates callers off the deprecated API and onto the new API so that ClusterNetworkingConfig can be protected via optimistic locking when appropriate. * Convert SetAuthPreferences usages to new Create/Update/Upsert API (#38895) Migrates callers off the deprecated API and onto the new API so that AuthPreferences can be protected via optimistic locking when appropriate. * Convert SetSessionRecordingConfig usages to new Create/Update/Upsert API (#39249) Migrates callers off the deprecated API and onto the new API so that SessionRecordingConfig can be protected via optimistic locking when appropriate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cluster config RPC service had a typo in the return type of ResetSessionRecordingConfig. Since our proto linter doesn't allow renaming, this removes the RPC entirely so that it can be added with the correct signature in a follow up. This service was only recently introduced, and is not exposed in any way with the Auth grpc server so removal is a safe operation.