Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration tests for plan selection #4545

Merged
merged 4 commits into from
Jul 7, 2023
Merged

Add integration tests for plan selection #4545

merged 4 commits into from
Jul 7, 2023

Conversation

guillaumelamirand
Copy link
Contributor

@guillaumelamirand guillaumelamirand commented Jul 5, 2023 •
edited by graviteeio

Description

Add integration tests for plan selection :

  • Only keyless
  • Only api-key
  • Only jwt
  • Only oauth2
  • keyless + api-key
  • keyless + api-key + jwt
  • keyless + api-key + jwt + oauth2

Additional context

馃摎聽聽View the storybook of this branch here

@guillaumelamirand guillaumelamirand requested review from a team as code owners July 5, 2023 15:06
@guillaumelamirand guillaumelamirand force-pushed the uc-plan-selection branch 3 times, most recently from 97f8c33 to 738fc58 Compare July 5, 2023 15:21
@guillaumelamirand guillaumelamirand enabled auto-merge (rebase) July 5, 2023 17:09
leleueri
leleueri reviewed Jul 6, 2023
View reviewed changes
Copy link
Contributor

@leleueri leleueri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but what should be the behaviour if multiple JWT plan are configured ?

@guillaumelamirand
Copy link
Contributor Author

guillaumelamirand commented Jul 6, 2023 •
edited

LGTM but what should be the behaviour if multiple JWT plan are configured ?

This will be part of another PR...which is coming; adding +400tests was enough for 1 PR I suppose 馃槃

@guillaumelamirand guillaumelamirand force-pushed the uc-plan-selection branch 2 times, most recently from f3035c4 to ff44ae1 Compare July 6, 2023 19:26
@guillaumelamirand
tests: implement single plan integration tests
e978c71
@guillaumelamirand
tests: add multi plan selection integration tests
060a76e
@guillaumelamirand
fix: properly handle token extraction
29c752f 
   - no Authorization header will not return any security token
   - no Bearer security schema value will not return a security token (Authorization: Basic 123456)
   - Empty Bearer or apikey will return an invalid security token
   - Bearer token without client_id will now return an invalid Security Token
@guillaumelamirand
fix: clean any security token if selection rule doesn't match
b8b3abb
@guillaumelamirand guillaumelamirand merged commit 48a9c28 into master Jul 7, 2023
36 of 37 checks passed
@guillaumelamirand guillaumelamirand deleted the uc-plan-selection branch July 7, 2023 08:34
@gaetanmaisse gaetanmaisse restored the uc-plan-selection branch July 7, 2023 09:10
@gaetanmaisse gaetanmaisse mentioned this pull request Jul 7, 2023
Merged
@mergify
Copy link

mergify bot commented Jul 7, 2023

鈿狅笍 The sha of the head commit of this PR conflicts with #4570. Mergify cannot evaluate rules on this PR. 鈿狅笍

@exalate-issue-sync exalate-issue-sync bot mentioned this pull request Jul 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leleueri leleueri leleueri approved these changes

@gaetanmaisse gaetanmaisse gaetanmaisse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@guillaumelamirand @leleueri @gaetanmaisse