-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
man_made=silo
is not being rendered
#2909
Comments
Sorry, didn't see that issue... |
man_made=silo
and man_made=storage_tank
are not being renderedman_made=silo
is not being rendered
2017-10-26 10:53 GMT+02:00 Thomas Arildsen <notifications@github.com>:
I recently changed a lot of silos and storage tanks along Aalborg Harbour
from building=yes to man_made=silo and man_made=storage_tank, because I
find that a more accurate reflection of what is actually there. However,
now they are no longer rendered on openstreetmap.org. Why does it not
render these - physically quite prominent - features?
IMHO you shouldn't replace tagged properties ("is a building in OSM") with
different properties, if both apply. You can keep the building tag (or
replace it with a more accurate value like "silo") and still add the
man_made tags. Obviously only in case, the tagged objects are considered
buildings in OSM (to see this, I'd ask on the tagging list, look up the
wiki _and taginfo_).
|
I suspect that silos should also have a building tag, so special rendering support is not necessary. |
I propose to close this issue and reopen it if there are man_made=silo objects that should not be tagged as building. |
If there are man_made=silo where building tag is wrong it would be a good idea to give example (with photo) at https://wiki.openstreetmap.org/wiki/Tag%3Aman_made%3Dsilo In my very limited experience building tag is applicable for such structures. |
I reopen this as I made a mistake closing this - bunker silo needs a different visual representation probably and I think silo is closer to storage tank (closed space), see the proposition for rendering them: #588 (comment). |
Do you have any example of object correctly tagged with man_made=silo where adding also building=silo would be wrong? |
I don't have an example on the map, but I think the example provided here would not classify as a building, while still being a storage of some kind: #588 (comment). |
Silos are more structures than buildings. If we accept that there is a separate tag for storage tanks (with man_made) the same should apply for silos! |
As silos are very similar to storage tanks outside (the difference between them is about what is inside - silos are for bulk materials and storage tanks are for liquids), I think both tags could be rendered with the same icon: related to #588 |
Another argument for not using building=silo: Storage tanks are never made from concrete, while silos are made from either steel (esp. North America / grains) or concrete. |
I am not convinced that icon is a good idea, I would just render them like building=*
I have no idea why this is relevant for either
|
I am not convinced that icon is a good idea, I would just render them like building=*
I have no idea why this is relevant for either
|
Since they are located outside city centers, I guess we could also render icon on high zoom, like z18+, since this is information which will not clutter space. However rendering them like buildings by default seems fine to me. People use building tags for very different structures, like silos or monuments, so it looks like intuitive enough. |
sent from a phone
On 18. May 2018, at 12:30, kocio-pl ***@***.***> wrote:
Since they are located outside city centers, I guess we could also render icon on high zoom, like z18+, since this is information which will not clutter space. However rendering them like buildings by default seems fine to me. People use building tags for very different structures, like silos or monuments, so it looks like intuitive enough.
what could be an argument for rendering an icon is that they are usually tall structures and can serve as landmarks.
|
I recently changed a lot of silos and storage tanks along Aalborg Harbour from
building=yes
toman_made=silo
andman_made=storage_tank
, because I find that a more accurate reflection of what is actually there. However, now they are no longer rendered on openstreetmap.org. Why does it not render these - physically quite prominent - features?The text was updated successfully, but these errors were encountered: