Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

man_made=silo is not being rendered #2909

Closed
ThomasA opened this issue Oct 26, 2017 · 17 comments · Fixed by #3384
Closed

man_made=silo is not being rendered #2909

ThomasA opened this issue Oct 26, 2017 · 17 comments · Fixed by #3384

Comments

@ThomasA
Copy link

ThomasA commented Oct 26, 2017

I recently changed a lot of silos and storage tanks along Aalborg Harbour from building=yes to man_made=silo and man_made=storage_tank, because I find that a more accurate reflection of what is actually there. However, now they are no longer rendered on openstreetmap.org. Why does it not render these - physically quite prominent - features?

@kocio-pl
Copy link
Collaborator

#588 was closed, but can be reopened (see also #372). Please change name of this ticket to drop man_made=silo, so the tickets don't overlap.

For every such object we need an idea how should they be rendered. Do you have one?

@kocio-pl kocio-pl added this to the New features milestone Oct 26, 2017
@ThomasA
Copy link
Author

ThomasA commented Oct 26, 2017

Sorry, didn't see that issue...

@kocio-pl kocio-pl changed the title man_made=silo and man_made=storage_tank are not being rendered man_made=silo is not being rendered Oct 26, 2017
@dieterdreist
Copy link

dieterdreist commented Oct 31, 2017 via email

@matkoniecz
Copy link
Contributor

matkoniecz commented Oct 31, 2017

I suspect that silos should also have a building tag, so special rendering support is not necessary.

@matkoniecz
Copy link
Contributor

I propose to close this issue and reopen it if there are man_made=silo objects that should not be tagged as building.

@matkoniecz
Copy link
Contributor

If there are man_made=silo where building tag is wrong it would be a good idea to give example (with photo) at https://wiki.openstreetmap.org/wiki/Tag%3Aman_made%3Dsilo

In my very limited experience building tag is applicable for such structures.

@kocio-pl
Copy link
Collaborator

I reopen this as I made a mistake closing this - bunker silo needs a different visual representation probably and I think silo is closer to storage tank (closed space), see the proposition for rendering them: #588 (comment).

@kocio-pl kocio-pl reopened this Mar 17, 2018
@matkoniecz
Copy link
Contributor

I reopen this as I made a mistake closing this

Do you have any example of object correctly tagged with man_made=silo where adding also building=silo would be wrong?

@kocio-pl
Copy link
Collaborator

I don't have an example on the map, but I think the example provided here would not classify as a building, while still being a storage of some kind: #588 (comment).

@eigenwillig
Copy link

Silos are more structures than buildings. If we accept that there is a separate tag for storage tanks (with man_made) the same should apply for silos!

@Tomasz-W
Copy link

Tomasz-W commented May 15, 2018

As silos are very similar to storage tanks outside (the difference between them is about what is inside - silos are for bulk materials and storage tanks are for liquids), I think both tags could be rendered with the same icon:

1

related to #588

@eigenwillig
Copy link

Another argument for not using building=silo:

Storage tanks are never made from concrete, while silos are made from either steel (esp. North America / grains) or concrete.

@matkoniecz
Copy link
Contributor

@Tomasz-W

I am not convinced that icon is a good idea, I would just render them like building=*

Another argument for not using building=silo:

I have no idea why this is relevant for either

  • whatever building=silo is a good idea (we already established that at least some silo are not taggable with building=silo)
  • I have no idea why construction material is relevant to using building tag (there are building made both from reinforced concrete and steel)

@matkoniecz
Copy link
Contributor

@Tomasz-W

I am not convinced that icon is a good idea, I would just render them like building=*

@eigenwillig

Another argument for not using building=silo:

I have no idea why this is relevant for either

  • whatever building=silo is a good idea (we already established that at least some silo are not taggable with building=silo)
  • I have no idea why construction material is relevant to using building tag (there are building made both from reinforced concrete and steel)

@kocio-pl
Copy link
Collaborator

Since they are located outside city centers, I guess we could also render icon on high zoom, like z18+, since this is information which will not clutter space. However rendering them like buildings by default seems fine to me. People use building tags for very different structures, like silos or monuments, so it looks like intuitive enough.

@dieterdreist
Copy link

dieterdreist commented May 18, 2018 via email

@Tomasz-W
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants