Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should provides go inside /stow/providers/*? #29

Closed
matryer opened this issue Jul 28, 2016 · 8 comments
Closed

Should provides go inside /stow/providers/*? #29

matryer opened this issue Jul 28, 2016 · 8 comments

Comments

@matryer
Copy link
Contributor

matryer commented Jul 28, 2016

We have a few root directories "test", "build", etc. Should we put provides inside a subdirectory or are we OK with them being alongside non-provider dirs?

@matryer matryer changed the title Should provides go inside /stow/providers/* Should provides go inside /stow/providers/*? Jul 28, 2016
@matryer
Copy link
Contributor Author

matryer commented Jul 28, 2016

@Xercoy
Copy link
Contributor

Xercoy commented Jul 29, 2016

👍 - Good idea, especially important as we add more providers. The test and build dirs already do the job of grouping relevant files together, so it makes sense to follow suit.

@dahernan
Copy link
Contributor

Maybe separate repositories for each provider, so if you use local + Azure, you don't have to pull AWS

@piotrrojek
Copy link
Contributor

I wouldn't make seperate repos for each. Each implementation is small enough that it doesn't hurt having it in the same repo IMHO.
Yes for "providers" folder inside repo though.

@matryer
Copy link
Contributor Author

matryer commented Jul 29, 2016

Trouble is the gigantic dependencies for some of the packages - it means Stow ends up having every other Go package in the world as a dependency.

@piotrrojek
Copy link
Contributor

Valid point.
Seperate repos then? stow-azure, stow-s3 etc.?

@matryer
Copy link
Contributor Author

matryer commented Aug 5, 2016

Turns out, go get for github.com/graymeta/stow will only get the root package, not all the dependencies for all providers. So we are ok to keep them in the same repo. But should we nest them inside providers?

@matryer
Copy link
Contributor Author

matryer commented Aug 23, 2016

I think it's simpler as it is. Closing.

@matryer matryer closed this as completed Aug 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants