New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate HSV->RGB or HSL->RGB conversion #25

Closed

TehShrike opened this issue Jun 27, 2017 · 1 comment

Contributor

TehShrike commented Jun 27, 2017 •

edited

Loading

HSV and HSL are very similar, and those conversions take a lot of code, so it's better not to keep both versions around.

Context: #24

When I tried removing either of the conversions, the output values changed enough that the tests wouldn't pass.

This implies that the conversions might be lossier than they should be, or one of them is less accurate than it should be.

Owner

graypegg commented Jul 2, 2017

Fixed in #26

graypegg closed this as completed

graypegg mentioned this issue

Refactoring to tiny functions #11

Closed

5 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment