Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dual axis distances #15

Closed
Lopezno68 opened this issue Apr 29, 2021 · 2 comments
Closed

Dual axis distances #15

Lopezno68 opened this issue Apr 29, 2021 · 2 comments

Comments

@Lopezno68
Copy link

Hello, i found a small error in the file limits.c
I think, the correct code is:
float fail_distance = (-settings.homing.dual_axis.fail_length_percent / 100.0f) * settings.axis[dual_motor_axis].max_travel;
fail_distance = min(fail_distance, settings.homing.dual_axis.fail_distance_max);
fail_distance = max(fail_distance, settings.homing.dual_axis.fail_distance_min);
Bye..

@terjeio
Copy link
Contributor

terjeio commented Apr 30, 2021

Good catch - a mistake on my part from when I switched from #defines for min and max to $-settings. Thanks for reporting!

@terjeio
Copy link
Contributor

terjeio commented May 5, 2021

Fix comitted.

@terjeio terjeio closed this as completed May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants