Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Do not pollute the global namespace #1401

Closed
arantius opened this Issue Aug 19, 2011 · 1 comment

Comments

Projects
None yet
1 participant
Collaborator

arantius commented Aug 19, 2011

Mozilla review of 0.9.9 said:

This version didn't pass full review because of the following issues ... you need to correct them to get full approval. Thanks.

  1. Your add-on creates the following non-namespaced variables in the global namespace, which could cause compatibility problems with other add-ons:
FileUtils NetUtil SCRIPT_ADDON_TYPE ScriptAddonFactoryByScript ScriptAddonReplaceScript

@arantius arantius closed this in 02126f1 Aug 19, 2011

@arantius arantius reopened this Aug 19, 2011

Collaborator

arantius commented Aug 19, 2011

Typed wrong ticket in the commit =( This is still open, #1400 was closed.

arantius added a commit to arantius/greasemonkey that referenced this issue Aug 22, 2011

Start splitting content/utils.js into separate modules.
Primary goal: reduce global-namespace pollution.
Also revamp GM_apiLeakCheck() to deal with the new paths involved.

Refs #1156 #1401

arantius added a commit to arantius/greasemonkey that referenced this issue Aug 22, 2011

@arantius arantius closed this Aug 22, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment