Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Do not pollute the global namespace #1401

Closed
arantius opened this Issue · 1 comment

1 participant

@arantius
Collaborator

Mozilla review of 0.9.9 said:

This version didn't pass full review because of the following issues ... you need to correct them to get full approval. Thanks.

4) Your add-on creates the following non-namespaced variables in the global namespace, which could cause compatibility problems with other add-ons:

FileUtils NetUtil SCRIPT_ADDON_TYPE ScriptAddonFactoryByScript ScriptAddonReplaceScript
@arantius arantius closed this in 02126f1
@arantius arantius reopened this
@arantius
Collaborator

Typed wrong ticket in the commit =( This is still open, #1400 was closed.

@arantius arantius referenced this issue from a commit in arantius/greasemonkey
@arantius arantius Start splitting content/utils.js into separate modules.
Primary goal: reduce global-namespace pollution.
Also revamp GM_apiLeakCheck() to deal with the new paths involved.

Refs #1156 #1401
7612b46
@arantius arantius referenced this issue from a commit in arantius/greasemonkey
@arantius arantius Completely refactor 'content/utils.js' into JS modules. 75c3b4e
@arantius arantius closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.