Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose sections as dialogs for accessibility. #3059

Merged
merged 1 commit into from Sep 9, 2020

Conversation

jcsteh
Copy link
Contributor

@jcsteh jcsteh commented Oct 23, 2019

Previously, screen readers reported nothing when the user switched to a new section. With this change, each section is exposed as a dialog, with the active dialog getting focus. This way, a screen reader will report the content of the new section as if a dialog appeared.

I separated this from #3058 because this one is a bit more controversial, since it messes with focus a tiny bit. Also, I'm totally blind, so I can't confirm whether focusing the sections causes problems visually.

Previously, screen readers reported nothing when the user switched to a new section.
With this change, each section is exposed as a dialog, with the active dialog getting focus.
This way, a screen reader will report the content of the new section as if a dialog appeared.
@jcsteh jcsteh mentioned this pull request Oct 23, 2019
@MarcoZehe
Copy link

MarcoZehe commented May 14, 2020

Any way to move this forward? This PR has been sitting open and unreviewed for several months.

@arantius arantius added this to the 4.10 milestone Sep 9, 2020
@arantius arantius merged commit 99501e3 into greasemonkey:master Sep 9, 2020
@arantius
Copy link
Collaborator

arantius commented Sep 9, 2020

I just wanted to comment to say: thanks so much for your contribution, sorry that it took so long to get to addressing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants