[MAINTENANCE] Add retries to requests in usage stats integration tests
#4600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
NathanFarmer
approved these changes
Mar 31, 2022
| def requests_session_with_retries() -> requests.Session: | ||
| # https://stackoverflow.com/a/35636367 | ||
| session = requests.Session() | ||
| retries = Retry(total=5, backoff_factor=1, status_forcelist=[502, 503, 504]) |
There was a problem hiding this comment.
I like how the backoff_factor works! We should keep an eye on how often we are using this though for performance reasons.
cdkini
deleted the
maintenance/set-retries-on-usage-stats-integration-tests
branch
Shinnnyshinshin
pushed a commit
that referenced
this pull request
Mar 31, 2022
…thub.com/great-expectations/great_expectations into bugfix/GREAT-725/fix-regex-param-builder * 'bugfix/GREAT-725/fix-regex-param-builder' of https://github.com/great-expectations/great_expectations: [FEATURE] Implement Multi-Column Domain Builder for Rule-Based Profiler (#4604) [MAINTENANCE] Add retries to `requests` in usage stats integration tests (#4600)
fjork3
pushed a commit
that referenced
this pull request
Mar 31, 2022
…sts (#4600) * feat: add retry fixture * chore: add type hinting
Shinnnyshinshin
pushed a commit
that referenced
this pull request
Apr 1, 2022
* develop: docs: fix snippet ref (#4609) [BUGFIX] Adjust output of `regex` ParameterBuilder to match Expectation (#4594) [FEATURE] Rule-Based Profiler: ColumnPairDomainBuilder (#4608) chore : update example notebook for RBP to include multicolumn domain builder (#4606) Pass random seed to bootstrap estimator (#4605) [MAINTENANCE] Miscellaneous test cleanup (#4602) [FEATURE] Implement Multi-Column Domain Builder for Rule-Based Profiler (#4604) [MAINTENANCE] Add retries to `requests` in usage stats integration tests (#4600) [MAINTENANCE] Standardize DomainBuilder Constructor Arguments Ordering (#4599) [MAINTENANCE] Instrument package dependencies (#4583) [BUGFIX] Adjust output of datetime `ParameterBuilder` to match Expectation (#4590)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.
Changes proposed in this pull request:
Definition of Done
Please delete options that are not relevant.
Thank you for submitting!