-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Update RBP notebook to include example for Multi-Column Domain Builder #4606
Merged
Shinnnyshinshin
merged 2 commits into
develop
from
feature/great-464/GREAT-720/update-notebook-for-multi-column-domain-builder
Mar 31, 2022
Merged
[FEATURE] Update RBP notebook to include example for Multi-Column Domain Builder #4606
Shinnnyshinshin
merged 2 commits into
develop
from
feature/great-464/GREAT-720/update-notebook-for-multi-column-domain-builder
Mar 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Shinnnyshinshin
requested review from
alexsherstinsky,
anthonyburdi,
cdkini,
donaldheppner and
NathanFarmer
March 31, 2022 16:57
…ok-for-multi-column-domain-builder
Shinnnyshinshin
commented
Mar 31, 2022
Comment on lines
+1275
to
+1277
"**`MultiColumnDomainBuilder`**\n", | ||
"\n", | ||
"This DomainBuilder outputs `multicolumn` Domains by taking in a column list in the `include_column_names` parameter. If no column names are specified (ie `include_column_names` is `None`), then the Domain is computed on the active Batch." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the example description, with code below
alexsherstinsky
approved these changes
Mar 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Shinnnyshinshin
deleted the
feature/great-464/GREAT-720/update-notebook-for-multi-column-domain-builder
branch
March 31, 2022 19:23
fjork3
pushed a commit
that referenced
this pull request
Mar 31, 2022
6 tasks
Shinnnyshinshin
pushed a commit
that referenced
this pull request
Apr 1, 2022
* develop: docs: fix snippet ref (#4609) [BUGFIX] Adjust output of `regex` ParameterBuilder to match Expectation (#4594) [FEATURE] Rule-Based Profiler: ColumnPairDomainBuilder (#4608) chore : update example notebook for RBP to include multicolumn domain builder (#4606) Pass random seed to bootstrap estimator (#4605) [MAINTENANCE] Miscellaneous test cleanup (#4602) [FEATURE] Implement Multi-Column Domain Builder for Rule-Based Profiler (#4604) [MAINTENANCE] Add retries to `requests` in usage stats integration tests (#4600) [MAINTENANCE] Standardize DomainBuilder Constructor Arguments Ordering (#4599) [MAINTENANCE] Instrument package dependencies (#4583) [BUGFIX] Adjust output of datetime `ParameterBuilder` to match Expectation (#4590)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
BatchRequest
is used to generate the Domain.Definition of Done
Please delete options that are not relevant.
Thank you for submitting!