Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Update RBP notebook to include example for Multi-Column Domain Builder #4606

Conversation

Shinnnyshinshin
Copy link
Contributor

Changes proposed in this pull request:

Definition of Done

Please delete options that are not relevant.

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests where applicable and made sure that new and existing tests are passing.
  • I have run any local integration tests and made sure that nothing is broken.

Thank you for submitting!

@Shinnnyshinshin Shinnnyshinshin self-assigned this Mar 31, 2022
@netlify
Copy link

netlify bot commented Mar 31, 2022

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 9e76beb
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/6245dd91eaef9800099d7da0
😎 Deploy Preview https://deploy-preview-4606--niobium-lead-7998.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Comment on lines +1275 to +1277
"**`MultiColumnDomainBuilder`**\n",
"\n",
"This DomainBuilder outputs `multicolumn` Domains by taking in a column list in the `include_column_names` parameter. If no column names are specified (ie `include_column_names` is `None`), then the Domain is computed on the active Batch."
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the example description, with code below

Copy link
Contributor

@alexsherstinsky alexsherstinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Shinnnyshinshin Shinnnyshinshin merged commit 68af0b8 into develop Mar 31, 2022
@Shinnnyshinshin Shinnnyshinshin deleted the feature/great-464/GREAT-720/update-notebook-for-multi-column-domain-builder branch March 31, 2022 19:23
fjork3 pushed a commit that referenced this pull request Mar 31, 2022
Shinnnyshinshin pushed a commit that referenced this pull request Apr 1, 2022
* develop:
  docs: fix snippet ref (#4609)
  [BUGFIX] Adjust output of `regex` ParameterBuilder to match Expectation (#4594)
  [FEATURE] Rule-Based Profiler: ColumnPairDomainBuilder (#4608)
  chore : update example notebook for RBP to include multicolumn domain builder (#4606)
  Pass random seed to bootstrap estimator (#4605)
  [MAINTENANCE] Miscellaneous test cleanup (#4602)
  [FEATURE] Implement Multi-Column Domain Builder for Rule-Based Profiler (#4604)
  [MAINTENANCE] Add retries to `requests` in usage stats integration tests (#4600)
  [MAINTENANCE] Standardize DomainBuilder Constructor Arguments Ordering (#4599)
  [MAINTENANCE] Instrument package dependencies (#4583)
  [BUGFIX] Adjust output of datetime `ParameterBuilder` to match Expectation (#4590)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants