-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Enable self-initializing ExpectColumnValueLengthsToBeBetween
#4985
[FEATURE] Enable self-initializing ExpectColumnValueLengthsToBeBetween
#4985
Conversation
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
…_expectations into feature/great-699/great-717/self-intializing-expect_column_value_lengths_to_be_between
…ing-expect_column_value_lengths_to_be_between
…umn_value_lengths_to_be_between' of https://github.com/great-expectations/great_expectations into feature/great-699/great-717/self-intializing-expect_column_value_lengths_to_be_between
…tions into feature/great-699/great-717/self-intializing-expect_column_value_lengths_to_be_between
cffdb80
to
8e3fcd6
Compare
…tions into feature/great-699/great-717/self-intializing-expect_column_value_lengths_to_be_between
"batch_id": "cf28d8229c247275c8cc0f41b4ceb62d", | ||
"column": "user_agent", | ||
"include_config": True, | ||
"max_value": 115, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cdkini It would be nice to also get an example where the min and the max values are different (and make sense to us). Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An additional test with different min/max would be nice.
…tions into feature/great-699/great-717/self-intializing-expect_column_value_lengths_to_be_between
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…ing-expect_column_value_lengths_to_be_between
…ing-expectations * develop: [FEATURE] `DataAssistant` plotting for non-sequential batches (#5126) Move upper bound on sqlalchemy to <2.0.0. (#5140) [FEATURE] Enable self-initializing `ExpectColumnValueLengthsToBeBetween` (#4985) Use `external_sqldialect` mark to skip tests during lightweight packaging test run. (#5139) [FEATURE] For OnboardingDataAssistant: Implement a TABLE Domain level rule to output "expect_table_columns_to_match_set" (#5137) [FEATURE] Giving the "expect_table_columns_to_match_set" Expectation Self-Initializing Capabilities. (#5136) [FEATURE] OnboardingDataAssistant: Introduce MeanTableColumnsSetMatchMultiBatchParameterBuilder (to enable expect_table_columns_to_match_set) (#5135) [FEATURE] Categorical Rule is added to OnboardingDataAssistant (#5134) CategoricalColumnDomainBuilder needs to accept limit_mode with dictionary type (#5127) add trino dialect (#5085) [BUGFIX] For DataAssistants, added try-except for Notebook tests (#5124) [MAINTENANCE] Sqlite specific tests for splitting and sampling (#5119) [FEATURE] DateTime Rule for OnboardingDataAssistant (#5121) [FEATURE] Onboarding DataAssistant: Numeric Rules and Relevant Metrics (#5120) [BUGFIX] Update `DataAssistant` notebook for new plotting API (#5118)
Changes proposed in this pull request:
ColumnValuesLengthMin
andColumnValuesLengthMax
metrics to enable self-intializingExpectColujmnValueLengthsToBeBetween
Definition of Done
Please delete options that are not relevant.
Thank you for submitting!