Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Enable self-initializing ExpectColumnValueLengthsToBeBetween #4985

Conversation

cdkini
Copy link
Member

@cdkini cdkini commented Apr 28, 2022

Changes proposed in this pull request:

Definition of Done

Please delete options that are not relevant.

  • My code follows the Great Expectations style guide
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added unit tests where applicable and made sure that new and existing tests are passing.
  • I have run any local integration tests and made sure that nothing is broken.

Thank you for submitting!

@netlify
Copy link

netlify bot commented Apr 28, 2022

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 3b93e63
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/6283bdd19e96310008734176
😎 Deploy Preview https://deploy-preview-4985--niobium-lead-7998.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cdkini cdkini self-assigned this Apr 28, 2022
@cdkini cdkini marked this pull request as draft April 28, 2022 23:38
…_expectations into feature/great-699/great-717/self-intializing-expect_column_value_lengths_to_be_between
…ing-expect_column_value_lengths_to_be_between
…umn_value_lengths_to_be_between' of https://github.com/great-expectations/great_expectations into feature/great-699/great-717/self-intializing-expect_column_value_lengths_to_be_between
…tions into feature/great-699/great-717/self-intializing-expect_column_value_lengths_to_be_between
@cdkini cdkini force-pushed the feature/great-699/great-717/self-intializing-expect_column_value_lengths_to_be_between branch from cffdb80 to 8e3fcd6 Compare May 13, 2022 15:00
…tions into feature/great-699/great-717/self-intializing-expect_column_value_lengths_to_be_between
@cdkini cdkini marked this pull request as ready for review May 16, 2022 21:54
"batch_id": "cf28d8229c247275c8cc0f41b4ceb62d",
"column": "user_agent",
"include_config": True,
"max_value": 115,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cdkini It would be nice to also get an example where the min and the max values are different (and make sense to us). Thanks!

Copy link
Contributor

@alexsherstinsky alexsherstinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An additional test with different min/max would be nice.

…tions into feature/great-699/great-717/self-intializing-expect_column_value_lengths_to_be_between
Copy link
Contributor

@alexsherstinsky alexsherstinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

…ing-expect_column_value_lengths_to_be_between
@cdkini cdkini enabled auto-merge (squash) May 17, 2022 15:23
@cdkini cdkini merged commit aac531b into develop May 17, 2022
@cdkini cdkini deleted the feature/great-699/great-717/self-intializing-expect_column_value_lengths_to_be_between branch May 17, 2022 15:51
Shinnnyshinshin pushed a commit that referenced this pull request May 17, 2022
…ing-expectations

* develop:
  [FEATURE] `DataAssistant` plotting for non-sequential batches (#5126)
  Move upper bound on sqlalchemy to <2.0.0. (#5140)
  [FEATURE] Enable self-initializing `ExpectColumnValueLengthsToBeBetween` (#4985)
  Use `external_sqldialect` mark to skip tests during lightweight packaging test run. (#5139)
  [FEATURE] For OnboardingDataAssistant: Implement a TABLE Domain level rule to output "expect_table_columns_to_match_set" (#5137)
  [FEATURE] Giving the "expect_table_columns_to_match_set" Expectation Self-Initializing Capabilities. (#5136)
  [FEATURE] OnboardingDataAssistant: Introduce MeanTableColumnsSetMatchMultiBatchParameterBuilder (to enable expect_table_columns_to_match_set) (#5135)
  [FEATURE] Categorical Rule is added to OnboardingDataAssistant (#5134)
  CategoricalColumnDomainBuilder needs to accept limit_mode with dictionary type (#5127)
  add trino dialect (#5085)
  [BUGFIX] For DataAssistants, added try-except for Notebook tests (#5124)
  [MAINTENANCE] Sqlite specific tests for splitting and sampling (#5119)
  [FEATURE] DateTime Rule for OnboardingDataAssistant (#5121)
  [FEATURE] Onboarding DataAssistant: Numeric Rules and Relevant Metrics (#5120)
  [BUGFIX] Update `DataAssistant` notebook for new plotting API (#5118)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants