[BUGFIX] Quick bugfix on all profile numeric column diff bounds expectations #5651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for niobium-lead-7998 pending review.Visit the deploys page to approve it
|
austiezr
approved these changes
Aug 3, 2022
austiezr
added
community
devrel
Shinnnyshinshin
pushed a commit
that referenced
this pull request
Aug 5, 2022
…etric-change * develop: (30 commits) Add mysql client to Dockerfile.tests (#5681) [DOCS]added guide how to use great expectations with aws glue (#5536) [MAINTENANCE] Assign `resource_type` in `InlineStoreBackend` constructor (#5671) [RELEASE] 0.15.17 (#5675) fix: patch issue with 'id' vs 'id_' (#5677) Tidying up the texts and config in gen; bump ops (#5678) [MAINTENANCE] data_context initial type checking (#5662) [FEATURE]Enable showing expectation suite by domain and by expectation_type -- from DataAssistantResult (#5673) [MAINTENANCE] Ensure that `id_` fields in Marshmallow schema serialize as `id` (#5660) [MAINTENANCE] Improve DateTime Conversion Candling in Comparison Metrics & Expectations and Provide a Clean Object Model for Metrics Computation Bundling (#5656) [MAINTENANCE] Only run Cloud E2E tests in primary pipeline Refactor docker test CI steps into jobs. (#5665) [MAINTENANCE] move tool config to pyproject.toml (#5649) add expectation for crc32 (#5580) Quick bug fix to all profile numeric column bounds expectations (#5651) Don't include 'test-pipeline' in extras_require dict (#5659) [ANALYTICS] add new invoke tasks to `tasks.py` and create new file `usage_stats_utils.py` (#5593) [MAINTENANCE] Introduce running tests in docker on our Azure CI pipeline. (#5646) [MAINTENANCE] Add E2E Cloud test for `DataContext.add_checkpoint()` (#5653) Make comparisons of aggregate values date aware (#5642) ...
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
_validatewould not account for invalid columns requested (i.e. non-numeric columns)_validatecarries out as expected.Previous Design Review notes:
Expectations fixed were added in the following: [FEATURE]expect_profile_numeric_columns_percent_diff_(inclusive bounds) #5586 , [FEATURE] expect_profile_numeric_columns_percent_diff_(less/greater)_than_threshold #5558 , [FEATURE] expect_profile_numeric_columns_percent_diff_between_exclusive_threshold_range #5537 , [FEATURE][CONTRIB] expect_profile_numeric_columns_diff_(less/greater)_than_or_equal_to_threshold #5522 and [FEATURE][MAINTENANCE] Revamped expect_profile_numeric_columns_diff_between_exclusive_threshold_range #5493
My code follows the Great Expectations style guide
I have performed a self-review of my own code