[BUGFIX] Quick bugfix on all profile numeric column diff bounds expectations #5651
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
_validate
would not account for invalid columns requested (i.e. non-numeric columns)_validate
carries out as expected.Previous Design Review notes:
Expectations fixed were added in the following: [FEATURE]expect_profile_numeric_columns_percent_diff_(inclusive bounds) #5586 , [FEATURE] expect_profile_numeric_columns_percent_diff_(less/greater)_than_threshold #5558 , [FEATURE] expect_profile_numeric_columns_percent_diff_between_exclusive_threshold_range #5537 , [FEATURE][CONTRIB] expect_profile_numeric_columns_diff_(less/greater)_than_or_equal_to_threshold #5522 and [FEATURE][MAINTENANCE] Revamped expect_profile_numeric_columns_diff_between_exclusive_threshold_range #5493
My code follows the Great Expectations style guide
I have performed a self-review of my own code