Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Add v2_api flag for v2_api specific tests #5803

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

anthonyburdi
Copy link
Member

Changes proposed in this pull request:

  • A new mark to use when tests are specific to only the v2 api
  • Addition of mark to one test and rename of test to clearly identify it as a v2 api specific test

Definition of Done

Please delete options that are not relevant.

@anthonyburdi anthonyburdi requested a review from a team August 22, 2022 15:55
@anthonyburdi anthonyburdi self-assigned this Aug 22, 2022
@ghost
Copy link

ghost commented Aug 22, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@netlify
Copy link

netlify bot commented Aug 22, 2022

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit ac8aef1
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/6303a6f9978cf900093c4c3b
😎 Deploy Preview https://deploy-preview-5803--niobium-lead-7998.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@anthonyburdi anthonyburdi enabled auto-merge (squash) August 22, 2022 16:05
@anthonyburdi anthonyburdi merged commit e49b5ca into develop Aug 22, 2022
@anthonyburdi anthonyburdi deleted the MAINTENANCE/none/none/add_v2_api_pytest_mark branch August 22, 2022 16:31
Shinnnyshinshin pushed a commit that referenced this pull request Aug 23, 2022
…k-spark

* develop: (21 commits)
  [MAINTENANCE] Write E2E Cloud test for RuleBasedProfiler creation and retrieval
  [MAINTENANCE] Make partitioning directives of PartitionParameterBuilder configurable (#5810)
  Add vectorized is_between for common numpy dtypes (#5711)
  [MAINTENANCE] Remove "copy.deepcopy()" calls from ValidationGraph (#5809)
  [FEATURE] Inline `ExpectationSuite` Rendering (#5726)
  [FEATURE] Support single-batch mode in MetricMultiBatchParameterBuilder (#5808)
  Fix how to create custom table expectation (#5807)
  [MAINTENANCE] Remove `ge_cloud_id` from `DataContext.add_profiler()` signature (#5804)
  Refactor convert_dictionary_to_parameter_node (#5805)
  [MAINTENANCE] Clean up `ge_cloud_id` reference from `DataContext` `ExpectationSuite` CRUD (#5791)
  Add v2_api flag for v2_api related tests (#5803)
  [MAINTENANCE] Refactor `save_profiler` to remove explicit `name` and `ge_cloud_id` args (#5792)
  [FEATURE] Enhance execution time measurement utility, and save `DomainBuilder` execution time per Rule of Rule-Based Profiler (#5796)
  [FEATURE] `query.pair_column` Metric (#5743)
  [MAINTENANCE] build-gallery enhancements (#5616)
  Remove xfail markers on cloud tests (#5793)
  Add square brackets to make the SA select work (#5780)
  [RELEASE] 0.15.19 (#5785)
  [MAINTENANCE] Temporarily xfail E2E Cloud tests due to Azure env var issues
  [BUGFIX] Enable "DataAssistantResult.__repr__()" to work properly in its subclasses. (#5786)
  ...
Shinnnyshinshin pushed a commit that referenced this pull request Aug 23, 2022
…k-pandas

* develop: (21 commits)
  [MAINTENANCE] Write E2E Cloud test for RuleBasedProfiler creation and retrieval
  [MAINTENANCE] Make partitioning directives of PartitionParameterBuilder configurable (#5810)
  Add vectorized is_between for common numpy dtypes (#5711)
  [MAINTENANCE] Remove "copy.deepcopy()" calls from ValidationGraph (#5809)
  [FEATURE] Inline `ExpectationSuite` Rendering (#5726)
  [FEATURE] Support single-batch mode in MetricMultiBatchParameterBuilder (#5808)
  Fix how to create custom table expectation (#5807)
  [MAINTENANCE] Remove `ge_cloud_id` from `DataContext.add_profiler()` signature (#5804)
  Refactor convert_dictionary_to_parameter_node (#5805)
  [MAINTENANCE] Clean up `ge_cloud_id` reference from `DataContext` `ExpectationSuite` CRUD (#5791)
  Add v2_api flag for v2_api related tests (#5803)
  [MAINTENANCE] Refactor `save_profiler` to remove explicit `name` and `ge_cloud_id` args (#5792)
  [FEATURE] Enhance execution time measurement utility, and save `DomainBuilder` execution time per Rule of Rule-Based Profiler (#5796)
  [FEATURE] `query.pair_column` Metric (#5743)
  [MAINTENANCE] build-gallery enhancements (#5616)
  Remove xfail markers on cloud tests (#5793)
  Add square brackets to make the SA select work (#5780)
  [RELEASE] 0.15.19 (#5785)
  [MAINTENANCE] Temporarily xfail E2E Cloud tests due to Azure env var issues
  [BUGFIX] Enable "DataAssistantResult.__repr__()" to work properly in its subclasses. (#5786)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants