[MAINTENANCE] Make partitioning directives of PartitionParameterBuilder configurable #5810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
August 15, 2022 18:08
…sky/core/util/enable_iddict_to_support_comparison_operations-2022_08_10-213
…stinsky/core/json_serialize_row_condition_and_enable_iddict_to_support_comparison_operations-2022_08_10-213' into develop
…rule_based_profiler/performance_improvements-2022_08_22-218' into feature/GREAT-761/GREAT-1196/alexsherstinsky/rule_based_profiler/parameter_builder/support_metric_multi_and_single_batch_parameter_builder-2022_08_22-218
…exsherstinsky/rule_based_profiler/performance_improvements-2022_08_22-218
…rule_based_profiler/performance_improvements-2022_08_22-218' into feature/GREAT-761/GREAT-1196/alexsherstinsky/rule_based_profiler/parameter_builder/support_metric_multi_and_single_batch_parameter_builder-2022_08_22-218
…_profiler/parameter_builder/support_metric_multi_and_single_batch_parameter_builder-2022_08_22-218' into pre_pr-prototype/maintenance/GREAT-761/alexsherstinsky/rule_based_profiler/performance_improvements-2022_08_22-218
…1/GREAT-1196/alexsherstinsky/rule_based_profiler/parameter_builder/support_metric_multi_and_single_batch_parameter_builder-2022_08_22-218
…sky/rule_based_profiler/parameter_builder/support_metric_multi_and_single_batch_parameter_builder-2022_08_22-218
…_profiler/parameter_builder/support_metric_multi_and_single_batch_parameter_builder-2022_08_22-218' into pre_pr-prototype/maintenance/GREAT-761/alexsherstinsky/rule_based_profiler/performance_improvements-2022_08_22-218
…emoving calls to copy.deepcopy() in ValidationGraph
…ore/metrics/remove_str_calls_from_iddict_remove_deepcopy_calls_from_validation_graph-2022_08_22-219
…stinsky/core/metrics/remove_str_calls_from_iddict_remove_deepcopy_calls_from_validation_graph-2022_08_22-219
…exsherstinsky/rule_based_profiler/performance_improvements-2022_08_22-218
…etrics/remove_str_calls_from_iddict_remove_deepcopy_calls_from_validation_graph-2022_08_22-219' into pre_pr-prototype/maintenance/GREAT-761/alexsherstinsky/rule_based_profiler/performance_improvements-2022_08_22-218
…98/alexsherstinsky/core/metrics/remove_str_calls_from_iddict_remove_deepcopy_calls_from_validation_graph-2022_08_22-219' into pre_pr-prototype/maintenance/GREAT-761/alexsherstinsky/rule_based_profiler/performance_improvements-2022_08_22-218
… are involved. With the change to PartitionParameterBuilder, IDDict can remain the same.
…stinsky/core/metrics/remove_str_calls_from_iddict_remove_deepcopy_calls_from_validation_graph-2022_08_22-219
…exsherstinsky/rule_based_profiler/performance_improvements-2022_08_22-218
…etrics/remove_str_calls_from_iddict_remove_deepcopy_calls_from_validation_graph-2022_08_22-219' into pre_pr-prototype/maintenance/GREAT-761/alexsherstinsky/rule_based_profiler/performance_improvements-2022_08_22-218
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
👇 Click on the image for a new way to code review
Legend |
…ule_based_profiler/parameter_builder/make_partition_parameter_builder_configurable_for_column_partition_options_bins_n_bins_allow_relative_error-2022_08_22-220
…ule_based_profiler/parameter_builder/make_partition_parameter_builder_configurable_for_column_partition_options_bins_n_bins_allow_relative_error-2022_08_22-220
alexsherstinsky
deleted the
maintenance/GREAT-761/GREAT-1199/alexsherstinsky/rule_based_profiler/parameter_builder/make_partition_parameter_builder_configurable_for_column_partition_options_bins_n_bins_allow_relative_error-2022_08_22-220
branch
Shinnnyshinshin
pushed a commit
that referenced
this pull request
Aug 23, 2022
…k-spark * develop: (21 commits) [MAINTENANCE] Write E2E Cloud test for RuleBasedProfiler creation and retrieval [MAINTENANCE] Make partitioning directives of PartitionParameterBuilder configurable (#5810) Add vectorized is_between for common numpy dtypes (#5711) [MAINTENANCE] Remove "copy.deepcopy()" calls from ValidationGraph (#5809) [FEATURE] Inline `ExpectationSuite` Rendering (#5726) [FEATURE] Support single-batch mode in MetricMultiBatchParameterBuilder (#5808) Fix how to create custom table expectation (#5807) [MAINTENANCE] Remove `ge_cloud_id` from `DataContext.add_profiler()` signature (#5804) Refactor convert_dictionary_to_parameter_node (#5805) [MAINTENANCE] Clean up `ge_cloud_id` reference from `DataContext` `ExpectationSuite` CRUD (#5791) Add v2_api flag for v2_api related tests (#5803) [MAINTENANCE] Refactor `save_profiler` to remove explicit `name` and `ge_cloud_id` args (#5792) [FEATURE] Enhance execution time measurement utility, and save `DomainBuilder` execution time per Rule of Rule-Based Profiler (#5796) [FEATURE] `query.pair_column` Metric (#5743) [MAINTENANCE] build-gallery enhancements (#5616) Remove xfail markers on cloud tests (#5793) Add square brackets to make the SA select work (#5780) [RELEASE] 0.15.19 (#5785) [MAINTENANCE] Temporarily xfail E2E Cloud tests due to Azure env var issues [BUGFIX] Enable "DataAssistantResult.__repr__()" to work properly in its subclasses. (#5786) ...
Shinnnyshinshin
pushed a commit
that referenced
this pull request
Aug 23, 2022
…k-pandas * develop: (21 commits) [MAINTENANCE] Write E2E Cloud test for RuleBasedProfiler creation and retrieval [MAINTENANCE] Make partitioning directives of PartitionParameterBuilder configurable (#5810) Add vectorized is_between for common numpy dtypes (#5711) [MAINTENANCE] Remove "copy.deepcopy()" calls from ValidationGraph (#5809) [FEATURE] Inline `ExpectationSuite` Rendering (#5726) [FEATURE] Support single-batch mode in MetricMultiBatchParameterBuilder (#5808) Fix how to create custom table expectation (#5807) [MAINTENANCE] Remove `ge_cloud_id` from `DataContext.add_profiler()` signature (#5804) Refactor convert_dictionary_to_parameter_node (#5805) [MAINTENANCE] Clean up `ge_cloud_id` reference from `DataContext` `ExpectationSuite` CRUD (#5791) Add v2_api flag for v2_api related tests (#5803) [MAINTENANCE] Refactor `save_profiler` to remove explicit `name` and `ge_cloud_id` args (#5792) [FEATURE] Enhance execution time measurement utility, and save `DomainBuilder` execution time per Rule of Rule-Based Profiler (#5796) [FEATURE] `query.pair_column` Metric (#5743) [MAINTENANCE] build-gallery enhancements (#5616) Remove xfail markers on cloud tests (#5793) Add square brackets to make the SA select work (#5780) [RELEASE] 0.15.19 (#5785) [MAINTENANCE] Temporarily xfail E2E Cloud tests due to Azure env var issues [BUGFIX] Enable "DataAssistantResult.__repr__()" to work properly in its subclasses. (#5786) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
bins,n_bins, andallow_relative_error) -- with same defaults as used inside the underlying"column.partition"metric -- at thePartitionParameterBuilderconstructor level. This achieves two benefits:A more general applicability of
PartitionParameterBuilder(no arguments are hard-coded); andThe given defaults insure fast operation and thus improve the performance of
OnboardingDataAssistant.PartitionParameterBuilderto demonstrate the more customizable behavior.OnboardingDataAssistantin aJupyternotebook.Please annotate your PR title to describe what the PR does, then give a brief bulleted description of your PR below. PR titles should begin with [BUGFIX], [FEATURE], [DOCS], or [MAINTENANCE]. If a new feature introduces breaking changes for the Great Expectations API or configuration files, please also add [BREAKING]. You can read about the tags in our contributor checklist.
Changes proposed in this pull request:
After submitting your PR, CI checks will run and @cla-bot will check for your CLA signature.
For a PR with nontrivial changes, we review with both design-centric and code-centric lenses.
In a design review, we aim to ensure that the PR is consistent with our relationship to the open source community, with our software architecture and abstractions, and with our users' needs and expectations. That review often starts well before a PR, for example in github issues or slack, so please link to relevant conversations in notes below to help reviewers understand and approve your PR more quickly (e.g.
closes #123).Previous Design Review notes:
Definition of Done
Please delete options that are not relevant.
Thank you for submitting!