Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug Since release ath10k-5.2 #208

Open
Oozil opened this issue Jan 7, 2023 · 5 comments
Open

bug Since release ath10k-5.2 #208

Oozil opened this issue Jan 7, 2023 · 5 comments

Comments

@Oozil
Copy link

Oozil commented Jan 7, 2023

I was able to open 4.9GHz channels and 5.9GHz channels on ATH10K-4.19 but the latest versions did not work and do not appear in the openWRT system interface such as ATH10K-4.19 only appear through this command putty ssh ( iw phy
How can I fix that on the latest releases

@Oozil Oozil changed the title bug Since release bug Since release ath10k-5.2 Jan 7, 2023
@lemoer
Copy link

lemoer commented Jan 13, 2023

You can change the following lines:

https://github.com/openwrt/openwrt/blob/openwrt-21.02/package/kernel/ath10k-ct/Makefile#L11-L13

If you do this, you should be able to use other versions in OpenWrt. If you did this, you can also hand in a pull-request at OpenWrt to make your "version bump" available to everyone (if you think that's worth for the community).

@greearb
Copy link
Owner

greearb commented Jan 13, 2023

The ath10k-ct driver versions need to match the backports, unless you have skill and willingness to effectively back/forward port the driver to work with whatever backports you are using. Also, the change in channel support might be from elsewhere in mac80211, not just ath10k. I did remove some out-of-tree hacks related to 4.9 from my kernel, not sure if that affected ath10k driver much or not.

@Oozil
Copy link
Author

Oozil commented Jan 13, 2023

تحتاج إصدارات برنامج التشغيل ath10k-ct إلى مطابقة المنافذ الخلفية ، ما لم تكن لديك المهارة والرغبة في إعادة / توجيه السائق بشكل فعال للعمل مع أي منفذ خلفي تستخدمه. أيضًا ، قد يكون التغيير في دعم القناة من مكان آخر في mac80211 ، وليس فقط ath10k. لقد قمت بإزالة بعض الاختراقات خارج الشجرة المتعلقة بـ 4.9 من نواة بلدي ، ولست متأكدًا مما إذا كان ذلك قد أثر على برنامج تشغيل ath10k كثيرًا أم لا.

Indeed, this modification affected ath10k, and I want to compile ath10k-4.19 with the latest commit from openwrt, but it gives me an error in the compilation only. It works with ath10k-5.15. How can I fix that?
openwrt/openwrt@9c0c1c4

@Oozil
Copy link
Author

Oozil commented Jan 13, 2023

Also, the channels that I added all work on 20mhz only, they do not work on 40mhz or 80mhz, while the same channels are on soft ddwrt and work on all bands .

Please give me a solution to the back port compatibility issue

@Oozil
Copy link
Author

Oozil commented Jan 13, 2023

The ath10k-ct driver versions need to match the backports, unless you have skill and willingness to effectively back/forward port the driver to work with whatever backports you are using. Also, the change in channel support might be from elsewhere in mac80211, not just ath10k. I did remove some out-of-tree hacks related to 4.9 from my kernel, not sure if that affected ath10k driver much or not.

In file included from :
drivers/usb/core/hub.c: In function 'hub_configure':
/home/Oozel/Pictures/openwrt/staging_dir/target-mips_24kc_musl/usr/include/mac80211-backport/backport/backport.h:10:31: error: too many arguments to function 'backport_usb_maxpacket'
10 | #define LINUX_BACKPORT(_sym) backport ##__sym
| ^~~~~~~~~
/home/Oozel/Pictures/openwrt/staging_dir/target-mips_24kc_musl/usr/include/mac80211-backport/linux/usb.h:11:23: note: in expansion of macro 'LINUX_BACKPORT'
11 | #define usb_maxpacket LINUX_BACKPORT(usb_maxpacket)
| ^~~~~~~~~~~~~~
drivers/usb/core/hub.c:1638:16: note: in expansion of macro 'usb_maxpacket'
1638 | maxp = usb_maxpacket(hdev, pipe, usb_pipeout(pipe));
| ^~~~~~~~~~~~~
In file included from drivers/usb/core/hub.c:23:
/home/Oozel/Pictures/openwrt/staging_dir/target-mips_24kc_musl/usr/include/mac80211-backport/linux/usb.h:7:19: note: declared here
7 | static inline u16 backport_usb_maxpacket(struct usb_device *udev, int pipe)
| ^~~~~~~~~~~~~~~~~~~~~~
make[7]: *** [scripts/Makefile.build:289: drivers/usb/core/hub.o] Error 1
make[7]: *** Waiting for unfinished jobs....
CC [M] net/ipv6/netfilter/nf_flow_table_ipv6.o
CC [M] net/netfilter/nf_nat_core.o
CC [M] net/netfilter/nf_nat_proto.o
CC [M] net/netfilter/nf_nat_helper.o
CC [M] net/netfilter/nf_nat_redirect.o
drivers/usb/core/message.c:2284:33: warning: 'struct usb_cdc_parsed_header' declared inside parameter list will not be visible outside of this definition or declaration
2284 | int cdc_parse_cdc_header(struct usb_cdc_parsed_header *hdr,
| ^~~~~~~~~~~~~~~~~~~~~
drivers/usb/core/message.c: In function 'cdc_parse_cdc_header':
drivers/usb/core/message.c:2301:34: error: invalid application of 'sizeof' to incomplete type 'struct usb_cdc_parsed_header'
2301 | memset(hdr, 0x00, sizeof(struct usb_cdc_parsed_header));
| ^~~~~~
drivers/usb/core/message.c:2302:12: error: invalid use of undefined type 'struct usb_cdc_parsed_header'
2302 | hdr->phonet_magic_present = false;
| ^~
drivers/usb/core/message.c:2332:28: error: invalid use of undefined type 'struct usb_cdc_parsed_header'
2332 | hdr->usb_cdc_country_functional_desc =
| ^~
drivers/usb/core/message.c:2345:28: error: invalid use of undefined type 'struct usb_cdc_parsed_header'
2345 | hdr->usb_cdc_acm_descriptor =
| ^~
drivers/usb/core/message.c:2358:28: error: invalid use of undefined type 'struct usb_cdc_parsed_header'
2358 | hdr->usb_cdc_call_mgmt_descriptor =
| ^~
drivers/usb/core/message.c:2364:28: error: invalid use of undefined type 'struct usb_cdc_parsed_header'
2364 | hdr->usb_cdc_dmm_desc =
| ^~
drivers/usb/core/message.c:2384:28: error: invalid use of undefined type 'struct usb_cdc_parsed_header'
2384 | hdr->usb_cdc_ncm_desc = (struct usb_cdc_ncm_desc *)buffer;
| ^~
drivers/usb/core/message.c:2390:28: error: invalid use of undefined type 'struct usb_cdc_parsed_header'
2390 | hdr->usb_cdc_mbim_desc = (struct usb_cdc_mbim_desc *)buffer;
| ^~
drivers/usb/core/message.c:2395:28: error: invalid use of undefined type 'struct usb_cdc_parsed_header'
2395 | hdr->usb_cdc_mbim_extended_desc =
| ^~
drivers/usb/core/message.c:2398:22: error: 'CDC_PHONET_MAGIC_NUMBER' undeclared (first use in this function)
2398 | case CDC_PHONET_MAGIC_NUMBER:
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/usb/core/message.c:2398:22: note: each undeclared identifier is reported only once for each function it appears in
drivers/usb/core/message.c:2399:28: error: invalid use of undefined type 'struct usb_cdc_parsed_header'
2399 | hdr->phonet_magic_present = true;
| ^~
drivers/usb/core/message.c:2415:12: error: invalid use of undefined type 'struct usb_cdc_parsed_header'
2415 | hdr->usb_cdc_union_desc = union_header;
| ^~
drivers/usb/core/message.c:2416:12: error: invalid use of undefined type 'struct usb_cdc_parsed_header'
2416 | hdr->usb_cdc_header_desc = header;
| ^~
drivers/usb/core/message.c:2417:12: error: invalid use of undefined type 'struct usb_cdc_parsed_header'
2417 | hdr->usb_cdc_mdlm_detail_desc = detail;
| ^~
drivers/usb/core/message.c:2418:12: error: invalid use of undefined type 'struct usb_cdc_parsed_header'
2418 | hdr->usb_cdc_mdlm_desc = desc;
| ^~
drivers/usb/core/message.c:2419:12: error: invalid use of undefined type 'struct usb_cdc_parsed_header'
2419 | hdr->usb_cdc_ether_desc = ether;
| ^~
make[7]: *** [scripts/Makefile.build:289: drivers/usb/core/message.o] Error 1
CC [M] net/netfilter/nf_nat_masquerade.o
CC [M] net/netfilter/nf_tables_core.o
CC [M] net/netfilter/nf_tables_api.o
make[6]: *** [scripts/Makefile.build:552: drivers/usb/core] Error 2
make[5]: *** [scripts/Makefile.build:552: drivers/usb] Error 2
make[4]: *** [Makefile:1903: drivers] Error 2
make[4]: *** Waiting for unfinished jobs....
CC [M] net/netfilter/nft_chain_filter.o
LD [M] net/ipv6/netfilter/nf_defrag_ipv6.o
CC [M] net/netfilter/nf_tables_trace.o
CC [M] net/netfilter/nft_immediate.o
CC [M] net/netfilter/nft_cmp.o
CC [M] net/netfilter/nft_range.o
CC [M] net/netfilter/nft_bitwise.o
CC [M] net/netfilter/nft_byteorder.o
CC [M] net/netfilter/nft_payload.o
CC [M] net/netfilter/nft_lookup.o
CC [M] net/netfilter/nft_dynset.o
CC [M] net/netfilter/nft_meta.o
CC [M] net/netfilter/nft_rt.o
CC [M] net/netfilter/nft_exthdr.o
CC [M] net/netfilter/nft_last.o
CC [M] net/netfilter/nft_chain_route.o
CC [M] net/netfilter/nf_tables_offload.o
CC [M] net/netfilter/nft_set_hash.o
CC [M] net/netfilter/nft_set_bitmap.o
CC [M] net/netfilter/nft_set_rbtree.o
CC [M] net/netfilter/nft_set_pipapo.o
CC [M] net/netfilter/nft_numgen.o
CC [M] net/netfilter/nft_ct.o
CC [M] net/netfilter/nft_flow_offload.o
CC [M] net/netfilter/nft_limit.o
CC [M] net/netfilter/nft_nat.o
CC [M] net/netfilter/nft_objref.o
CC [M] net/netfilter/nft_quota.o
CC [M] net/netfilter/nft_reject.o
CC [M] net/netfilter/nft_reject_inet.o
CC [M] net/netfilter/nft_counter.o
CC [M] net/netfilter/nft_log.o
CC [M] net/netfilter/nft_masq.o
CC [M] net/netfilter/nft_redir.o
CC [M] net/netfilter/nft_hash.o
CC [M] net/netfilter/nft_fib.o
CC [M] net/netfilter/nft_fib_inet.o
CC [M] net/netfilter/nft_chain_nat.o
CC [M] net/netfilter/nf_flow_table_core.o
CC [M] net/netfilter/nf_flow_table_ip.o
CC [M] net/netfilter/nf_flow_table_offload.o
CC [M] net/netfilter/nf_flow_table_inet.o
LD [M] net/netfilter/nf_conntrack.o
LD [M] net/netfilter/nf_nat.o
LD [M] net/netfilter/nf_tables.o
LD [M] net/netfilter/nf_flow_table.o
make[4]: Leaving directory '/home/Oozel/Pictures/openwrt/build_dir/target-mips_24kc_musl/linux-ath79_nand/linux-5.15.85'
make[3]: *** [Makefile:123: /home/Oozel/Pictures/openwrt/build_dir/target-mips_24kc_musl/linux-ath79_nand/ath10k-ct-regular/ath10k-ct-2021-06-03-b44cd7b2/.built] Error 2
make[3]: Leaving directory '/home/Oozel/Pictures/openwrt/package/kernel/ath10k-ct'
time: package/kernel/ath10k-ct/regular/compile#169.53#25.84#29.77
ERROR: package/kernel/ath10k-ct failed to build (build variant: regular).
make[2]: *** [package/Makefile:116: package/kernel/ath10k-ct/compile] Error 1
make[2]: Leaving directory '/home/Oozel/Pictures/openwrt'
make[1]: *** [package/Makefile:110: /home/Oozel/Pictures/openwrt/staging_dir/target-mips_24kc_musl/stamp/.package_compile] Error 2
make[1]: Leaving directory '/home/Oozel/Pictures/openwrt'
make: *** [/home/Oozel/Pictures/openwrt/include/toplevel.mk:231: world] Error 2``

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants