New NVT cross references data handling #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janowagner
added
the
work in progress
janowagner
force-pushed
the
new_xrefs
branch
2 times, most recently
from
307ad9b
to
ffb65c1
Compare
janowagner
removed
the
work in progress
Call nvti_add_ref() directly instead of the plug_set_xref (). Remove plug_set_xref(), its knowledge about syntax isn't need anymore.
Which means to not use nvti_add_cve() and nvti_add_bid().
This introduces the option to add bulk of comma-separated cross-references. Also documentation is added to this function to explains its use. This way, script_cve_id() and script_bugtraq_id() are redundant and can easily be transformed into script_xref() calls.
jjnicola
approved these changes
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unified handling of cross references (CVE, BID, XREF) allows
Ultimately it allows to get rid of script_cve_id() and script_bugtraq_id() in favor
of using only script_xref().
This PR requires and corresponds with greenbone/gvm-libs#225