Drop otp command NVT_INFO #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janowagner
force-pushed
the
drop_otp_nvt_info
branch
from
10424cd
to
fea8c84
Compare
Also a couple of static functions used only by/via comm_send_nvt_info() are removed.
janowagner
force-pushed
the
drop_otp_nvt_info
branch
from
25705d6
to
6f19bc1
Compare
jjnicola
approved these changes
May 31, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the command NVT_INFO from the OTP protocol.
Subsequently, several code parts are not used anymore and are removed.
Updating of NVT meta data now needs to be done via the redis store.
ospd-openvas in master branch implements this and offers the meta data via OSP.
gvmd in master branch is able to load the NVT meta data via OSP.
So, it is recommended to have the ospd-openvas daemon running
and to launch gvmd with specifiying the file socket path where ospd-openvas
is listening.
This is the first step of reducing OTP which will be removed entirely:
https://community.greenbone.net/t/goodbye-otp/
The code documentation coverage unfortunately decreases. This is because several
well documented functions are removed.
This pull request replaces the earlier PR #278