Remove dead code about tags. #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Years ago there were two scanner configurations "result_prepend_tags" and "result_append_tags" for the transition of breaking up the descripiton block. These settings are not used or needed anymore. So, the related code is now removed. This eliminates yet another place with knowledge about internal representation of tags.
janowagner
force-pushed
the
resolve_tags
branch
from
c00bf25
to
7dd3bc0
Compare
jjnicola
approved these changes
Sep 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Years ago there were two scanner configurations "result_prepend_tags"
and "result_append_tags" for the transition of breaking up the
descripiton block. These settings are not used or needed anymore.
So, the related code is now removed. This eliminates yet another place
with knowledge about internal representation of tags.