-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store results in main_kb instead of host_kb #550
Merged
jjnicola
merged 14 commits into
greenbone:master
from
jjnicola:result-single-key-mainkb
Jul 16, 2020
Merged
Store results in main_kb instead of host_kb #550
jjnicola
merged 14 commits into
greenbone:master
from
jjnicola:result-single-key-mainkb
Jul 16, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Host status is also stored in the same internal/status key in the main_kb, and for that the host ip is added to the status result.
…n the main kb. For that, the host ip is prefixed to the timestamp. Also, simplify the function host_set_time()
Instead of using a special key internal/start_time and internal/end_time, the messages are stored as results in the internal/results key in the main_kb.
jjnicola
force-pushed
the
result-single-key-mainkb
branch
from
July 13, 2020 10:58
6fd30f3
to
6724fba
Compare
jjnicola
force-pushed
the
result-single-key-mainkb
branch
from
July 13, 2020 11:09
19e67a2
to
fe31cf3
Compare
jjnicola
force-pushed
the
result-single-key-mainkb
branch
from
July 15, 2020 07:35
2a3c945
to
aec9776
Compare
ArnoStiefvater
requested changes
Jul 16, 2020
doc/redis_data_model.md
Outdated
Comment on lines
106
to
108
The task main KB is used for storing the results. Each result produced by a | ||
NVT for a host, will be stored in this KB, and the progress status of the | ||
current scanned hosts as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second sentence could be something like
"Each result produced by NVTs as well as the the progress status of the
currently scanned hosts will be stored in this KB."
ArnoStiefvater
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also progress status and start_time and end_time messages are stored in the main kb.
This allows openvas to release the host kb when the host scan finishes.
The results stored in internal/results and internal/status keys in the main task DB, include now the host ip address.