Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store results in main_kb instead of host_kb #550

Merged
merged 14 commits into from
Jul 16, 2020

Conversation

jjnicola
Copy link
Member

Also progress status and start_time and end_time messages are stored in the main kb.
This allows openvas to release the host kb when the host scan finishes.
The results stored in internal/results and internal/status keys in the main task DB, include now the host ip address.

Host status is also stored in the same internal/status key in the main_kb,
and for that the host ip is added to the status result.
…n the main kb.

For that, the host ip is prefixed to the timestamp.

Also, simplify the function host_set_time()
Instead of using a special key internal/start_time and internal/end_time,
the messages are stored as results in the internal/results key in the main_kb.
@jjnicola jjnicola marked this pull request as ready for review July 13, 2020 11:17
@jjnicola jjnicola marked this pull request as ready for review July 15, 2020 07:36
Comment on lines 106 to 108
The task main KB is used for storing the results. Each result produced by a
NVT for a host, will be stored in this KB, and the progress status of the
current scanned hosts as well.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second sentence could be something like
"Each result produced by NVTs as well as the the progress status of the
currently scanned hosts will be stored in this KB."

@jjnicola jjnicola merged commit bebc714 into greenbone:master Jul 16, 2020
@jjnicola jjnicola deleted the result-single-key-mainkb branch July 16, 2020 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants