This repository has been archived by the owner on Nov 29, 2021. It is now read-only.
Use an iterator to get the vts when get_vts cmd is called #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
==========================================
+ Coverage 73.66% 73.71% +0.05%
==========================================
Files 18 18
Lines 2119 2127 +8
==========================================
+ Hits 1561 1568 +7
- Misses 558 559 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
==========================================
+ Coverage 73.66% 73.71% +0.05%
==========================================
Files 18 18
Lines 2119 2127 +8
==========================================
+ Hits 1561 1568 +7
- Misses 558 559 +1
Continue to review full report at Codecov.
|
bjoernricks
suggested changes
Mar 4, 2020
| @@ -546,7 +546,6 @@ def test_scan_with_error(self): | |||
| ) | |||
| response = fs.get_response() | |||
| scan_id = response.findtext('id') | |||
| print(scan_id) | |||
bjoernricks
suggested changes
Mar 4, 2020
ospd/vts.py
Outdated
Comment on lines
56
to
58
| def items(self): | ||
| return self.vts.items() | ||
|
|
There was a problem hiding this comment.
IMHO we can ensure that items already returns an iterator.
Suggested change
| def items(self): | |
| return self.vts.items() | |
| def items(self) -> Iterator[Tuple[str, str]]: | |
| return iter(self.vts.items()) | |
ospd/ospd.py
Outdated
Comment on lines
944
to
947
| def get_vt_iterator(self) -> Iterable: | ||
| """ Return iterator object for getting elements | ||
| from the VTs dictionary. """ | ||
| return iter(self.vts.items()) |
There was a problem hiding this comment.
Suggested change
| def get_vt_iterator(self) -> Iterable: | |
| """ Return iterator object for getting elements | |
| from the VTs dictionary. """ | |
| return iter(self.vts.items()) | |
| def get_vt_iterator(self) -> Iterator[Tuple[str,str]]: | |
| """ Return iterator object for getting elements | |
| from the VTs dictionary. """ | |
| return self.vts.items() |
bjoernricks
approved these changes
Mar 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.