Get vts metadata from redis and reduce stored data in cache. #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The iterator uses get_single_vt() to get each vt from redis. It returns a tuple(vt_id, vt_values_dict), as expected for ospd. Improve readability of load_vts(), spliting and using the created get_single_vt() Also, load_vts() loads now the necessary to run a scan, making the vt cache smaller.
Also remove OID from the vt dict, since the key is already the OID
bjoernricks
requested changes
Mar 4, 2020
Codecov Report
@@ Coverage Diff @@
## master #205 +/- ##
=========================================
+ Coverage 77.27% 77.38% +0.1%
=========================================
Files 5 5
Lines 1219 1260 +41
=========================================
+ Hits 942 975 +33
- Misses 277 285 +8
Continue to review full report at Codecov.
|
jjnicola
removed
the
Work in progress
bjoernricks
approved these changes
Mar 4, 2020
ArnoStiefvater
pushed a commit
to ArnoStiefvater/ospd-openvas
that referenced
this pull request
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on PR greenbone/ospd#216. After merging, Pipfile.lock must be updated.