This repository has been archived by the owner on Nov 29, 2021. It is now read-only.
Fix resume task. #464
Merged
Fix resume task. #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, the task is stopped and quickly resumed. In this cases there was race condition in which the scan id is present in the scan table but there is no target information. Although the quick resume can lead first into a stopped and scan followed by an interrupted scan, finally the scan can be resumed.
Codecov Report
@@ Coverage Diff @@
## ospd-21.04 #464 +/- ##
==============================================
- Coverage 74.67% 74.65% -0.03%
==============================================
Files 23 23
Lines 2638 2643 +5
==============================================
+ Hits 1970 1973 +3
- Misses 668 670 +2
Continue to review full report at Codecov.
|
ArnoStiefvater
approved these changes
Oct 12, 2021
jjnicola
added
the
backport-to-main
y0urself
added a commit
that referenced
this pull request
Oct 13, 2021
Fix resume task. (backport #464)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fix resume task
Why:
In some cases, the task is stopped and quickly resumed. In this cases there was race condition
in which the scan id is present in the scan table but there is no target information.
Although the quick resume can lead first into a stopped and scan followed by an interrupted scan,
finally the scan can be resumed.
How:
Start, stop and resume task, until you get the interrupted scan. With the patch, resuming the task should finally work and the scan should end successfully.
Checklist: