This repository has been archived by the owner on Nov 29, 2021. It is now read-only.
Fix resume task. (backport #464) #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
In some cases, the task is stopped and quickly resumed. In this cases there was race condition in which the scan id is present in the scan table but there is no target information. Although the quick resume can lead first into a stopped and scan followed by an interrupted scan, finally the scan can be resumed. (cherry picked from commit d4bf472)
Codecov Report
@@ Coverage Diff @@
## master #470 +/- ##
==========================================
- Coverage 75.28% 75.25% -0.03%
==========================================
Files 23 23
Lines 2670 2675 +5
==========================================
+ Hits 2010 2013 +3
- Misses 660 662 +2
Continue to review full report at Codecov.
|
y0urself
approved these changes
Oct 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #464 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/