Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Review Requested] Update Underway #986
[Review Requested] Update Underway #986
Changes from 12 commits
29b7ea5
066b3cc
7facd07
d90da3d
f36cf12
8fb8b56
cd2bfc6
52316d6
a527157
e183c15
3e649d9
65bfcc9
b5f65f4
60b2712
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we make it alphabetical so we can give clear instructions to new Version 2.0 authors? That may be too tricky if some authors are both v1 and v2 authors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if there's a way to have the v1 field become the author contributions grouping there and the v2 field become the same (instead of just true/empty). That opens up the potential to put author contributions on mouseover, and also to sort the list dynamically (say, alphabetically within contribution bands) as people contribute.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tracking the contribution types in the metadata file makes sense to me. Should we save v2 author ordering and mouseover contributions for a follow up issues/pull request?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this
groupby
is what is causing the build errors. The changes in 65bfcc9 may not be needed?