Modifications to the Manubot section #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
dhimmel
commented
Apr 2, 2019
dhimmel
commented
Apr 2, 2019
dhimmel
commented
Apr 2, 2019
|
@agitter can you review now. Also should we add the contribution video in this PR or another? |
agitter
requested changes
Apr 3, 2019
This was referenced Apr 4, 2019
Closed
agitter
reviewed
Apr 5, 2019
|
@dhimmel I re-reviewed and resolved all of my old comments that have been addressed. There are still a few previous questions and one new comment. Can you please resolve those conversations if you do not think a change is needed or make updates if you do? |
|
@agitter somehow I overlooked several of your comments. Everything should now be addressed except for the one-sentence-per-line paragraph, which may need further discussion. |
agitter
approved these changes
Apr 5, 2019
|
Thanks @dhimmel, your latest comments and commit addressed everything. You can proceed to merge after resolving the new conflict. |
Resolve conflict & add missing newline
agitter
pushed a commit
that referenced
this pull request
Apr 5, 2019
This build is based on dd08829. This commit was created by the following Travis CI build and job: https://travis-ci.org/greenelab/meta-review/builds/516248509 https://travis-ci.org/greenelab/meta-review/jobs/516248510 [ci skip] The full commit message that triggered this build is copied below: Major revisions to the Manubot features section Merges #186 Closes #76 Closes #104 Closes #128 Closes #141 Closes #155 Closes #174
agitter
pushed a commit
that referenced
this pull request
Apr 5, 2019
This build is based on dd08829. This commit was created by the following Travis CI build and job: https://travis-ci.org/greenelab/meta-review/builds/516248509 https://travis-ci.org/greenelab/meta-review/jobs/516248510 [ci skip] The full commit message that triggered this build is copied below: Major revisions to the Manubot features section Merges #186 Closes #76 Closes #104 Closes #128 Closes #141 Closes #155 Closes #174
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress.
This PR will address the following issues:
@agitter let me know if there are any other loose ends that this PR could address/