Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Reruns after pushing lockfile commit #24

Closed
john-griffin opened this issue May 25, 2017 · 5 comments
Closed

CI Reruns after pushing lockfile commit #24

john-griffin opened this issue May 25, 2017 · 5 comments

Comments

@john-griffin
Copy link

After a greenkeeper successful upgrades a dependancy and the lockfile commit is pushed, travis creates new jobs because of the new commit. Is there a way around this as it's effectively testing the same build or is this just a limitation of regenerating the lockfile independently?

@StephanBijzitter
Copy link

You could test the commit message on your CI, and skip the build based on that. It won't completely skip, but it would be a lot faster as it won't have to install everything and then test everything.

@boennemann
Copy link
Member

We could think about optionally adding [ci skip] to the commit message.
We shouldn't make it a default though, as with GitHub's required status feature you won't be able to merge the Greenkeeper PR w/o the Travis status.

@john-griffin
Copy link
Author

Would it still work with github required status if it amended the greenkeeper commit with the lockfile and added [ci skip] to the message?

@boennemann
Copy link
Member

No unfortunately not. Also ammending to the first commit makes it way harder to detect "firstPush" on other platforms than Travis CI.

@janl
Copy link
Contributor

janl commented Oct 18, 2017

Closing until somebody comes up with a satisfactory solution

@janl janl closed this as completed Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants