PLANET-7561 Move Blank Page pattern to the theme #2316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mleray
force-pushed
the
move-blank-page-pattern
branch
from
db7d144
to
4305684
Compare
planet-4
added a commit
to greenpeace/planet4-test-umbriel
that referenced
this pull request
Jul 1, 2024
/unhold 379b279c-69b3-4022-b5f1-81024c641e70
Test instance is ready 🚀🌑 umbriel | admin | blocks report | CircleCI | composer-local.json ⌚ 2024.07.01 10:22:41 |
mleray
commented
Jul 1, 2024
| DeepDive::class, | ||
| HighlightedCta::class, | ||
| Issues::class, |
There was a problem hiding this comment.
I've reorganised these so that they are in alphabetical order
mleray
commented
Jul 1, 2024
| @@ -17,17 +17,15 @@ | |||
| class DeepDive extends BlockPattern | |||
| { | |||
| /** | |||
| * Returns the pattern name. | |||
| * @inheritDoc | |||
There was a problem hiding this comment.
This notation allows us to avoid repeating ourselves
It used to be in the plugin
mleray
force-pushed
the
move-blank-page-pattern
branch
from
4305684
to
c5246e1
Compare
planet-4
added a commit
to greenpeace/planet4-test-umbriel
that referenced
this pull request
Jul 1, 2024
/unhold fde75baf-9e52-4c47-a508-f994bcec5bc1
comzeradd
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See PLANET-7561
It used to be in the plugin, see related PR
Testing
Either on local or on the umbriel test instance, you should be able to add a Blank Page pattern just like before.