Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PVT#181020089] Implement better deployment monitoring and try out asset precompilation in GAH #2157

Merged
merged 92 commits into from
Apr 27, 2022
Merged

[PVT#181020089] Implement better deployment monitoring and try out asset precompilation in GAH #2157

merged 92 commits into from
Apr 27, 2022

Commits on Apr 14, 2022

  1. how bad are the logs if we just time all of the commands in deploy_ta… 

    …sks?
    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    915266c View commit details
    Browse the repository at this point in the history

  2. experimenting with checksum-based assets 

     #Please enter the commit message for your changes. Lines starting
    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    fe18b24 View commit details
    Browse the repository at this point in the history

  3. fix path to checksum script

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    da69f44 View commit details
    Browse the repository at this point in the history

  4. move checksum call to root dir

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    52a58d0 View commit details
    Browse the repository at this point in the history

  5. GHA load test?

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    d5d6afd View commit details
    Browse the repository at this point in the history

  6. ruby container

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    367574f View commit details
    Browse the repository at this point in the history

  7. fix concurrency group, duh

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    dd27e0e View commit details
    Browse the repository at this point in the history

  8. we don't need to login to ecr

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    5d2addb View commit details
    Browse the repository at this point in the history

  9. still missing some steps

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    59c492f View commit details
    Browse the repository at this point in the history

  10. steeeeeppppsss

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    6745ad7 View commit details
    Browse the repository at this point in the history

  11. asset precompilation goes brrrrrr

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    8776c29 View commit details
    Browse the repository at this point in the history

  12. env

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    c1b4d07 View commit details
    Browse the repository at this point in the history

  13. debug

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    5b82d6f View commit details
    Browse the repository at this point in the history

  14. pass assets_prefix

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    c54744d View commit details
    Browse the repository at this point in the history

  15. Narrow checksum files

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    06fed65 View commit details
    Browse the repository at this point in the history

  16. debug

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    eef0c38 View commit details
    Browse the repository at this point in the history

  17. Refactor checksumming to actually work (well, probably)

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    5a445aa View commit details
    Browse the repository at this point in the history

  18. Forgot to install better tar [gh:rebuild]

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    b9e3d40 View commit details
    Browse the repository at this point in the history

  19. remove precompiling in deploy to save time, since we're not using it … 

    …anyway
    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    defc5d4 View commit details
    Browse the repository at this point in the history

  20. Try out pulling secrets for real

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    5dffdfe View commit details
    Browse the repository at this point in the history

  21. ensure compile_assets.rb is executable?

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    52d2434 View commit details
    Browse the repository at this point in the history

  22. cache bundle?

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    c6de3a3 View commit details
    Browse the repository at this point in the history

  23. try a different way to cache bundle

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    c108c4d View commit details
    Browse the repository at this point in the history

  24. oops, cache step should go at the beginning

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    99c1c6c View commit details
    Browse the repository at this point in the history

  25. and i forgot about tar again

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    1101ade View commit details
    Browse the repository at this point in the history

  26. and and, bump number of bundle jobs to 10

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    b01fb4a View commit details
    Browse the repository at this point in the history

  27. install awscli

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    2863c7f View commit details
    Browse the repository at this point in the history

  28. bundle cache not working, try echoing path to see if we have the righ… 

    …t one cached
    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    8360052 View commit details
    Browse the repository at this point in the history

  29. when you forget to hit ctrl-s....

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    b8fe555 View commit details
    Browse the repository at this point in the history

  30. try caching /usr/local/bundle

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    f95c5e2 View commit details
    Browse the repository at this point in the history

  31. Install GNU tar even earlier

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    aab7fe5 View commit details
    Browse the repository at this point in the history

  32. echo checksum earlier in compile_assets.rb

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    00f12ef View commit details
    Browse the repository at this point in the history

  33. more debug

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    e598816 View commit details
    Browse the repository at this point in the history

  34. ensure ls debug actually displays?

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    3211574 View commit details
    Browse the repository at this point in the history

  35. pesky -l flag

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    96a9aae View commit details
    Browse the repository at this point in the history

  36. okay, what if i dl the tar and check it?

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    daf6c38 View commit details
    Browse the repository at this point in the history

  37. yml syntax

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    92829ef View commit details
    Browse the repository at this point in the history

  38. why??

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    084208a View commit details
    Browse the repository at this point in the history

  39. still debugging/trying to get a tar artifact

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    5bf171a View commit details
    Browse the repository at this point in the history

  40. disable other github workflows to reduce noise (sorry, should have do… 

    …ne this at the beginning...)
    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    5cb0b6e View commit details
    Browse the repository at this point in the history

  41. yes thank you github

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    70bd57f View commit details
    Browse the repository at this point in the history

  42. maybe fix artifacts?

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    42142b6 View commit details
    Browse the repository at this point in the history

  43. throw some more tar flags at it

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    b56a1c1 View commit details
    Browse the repository at this point in the history

  44. We're close! It generated the same hash as local last time!!

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    100b73a View commit details
    Browse the repository at this point in the history

  45. try to fix s3 assets exist check

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    a3c3084 View commit details
    Browse the repository at this point in the history

  46. this is why you don't do dev at 1am

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    1cdc93a View commit details
    Browse the repository at this point in the history

  47. It's working, maybe. Re-enable image build?

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    f8aa89f View commit details
    Browse the repository at this point in the history

  48. cleanup some stuff

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    5f29b4a View commit details
    Browse the repository at this point in the history

  49. iterate on monitoring

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    34b4a4b View commit details
    Browse the repository at this point in the history

  50. Include env secrets in asset checksum

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    fc58228 View commit details
    Browse the repository at this point in the history

  51. Don't overwrite client environment variables in workflow config

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    5c9e187 View commit details
    Browse the repository at this point in the history

  52. yml syntax

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    16b7aa7 View commit details
    Browse the repository at this point in the history

  53. Try running shell commands differently in asset_compiler

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    d3ed767 View commit details
    Browse the repository at this point in the history

  54. pull secrets before clobber

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    60e8b1d View commit details
    Browse the repository at this point in the history

  55. add some env vars back, load .env manually

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    c3d9b80 View commit details
    Browse the repository at this point in the history

  56. don't use test db yml

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    8229c06 View commit details
    Browse the repository at this point in the history

  57. slight logging adjustments

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    757426a View commit details
    Browse the repository at this point in the history

  58. glam up timing code and try out TWO clients (wow!)

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    fc2742e View commit details
    Browse the repository at this point in the history

  59. build matrix?

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    8edf716 View commit details
    Browse the repository at this point in the history

  60. try building everything, split up into 4 concurrent jobs

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    d6ae0ca View commit details
    Browse the repository at this point in the history

  61. Replace //=require with @import to see if it speeds up precompiling? 

    https://github.com/rails/sass-rails#important-note
    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    641eabc View commit details
    Browse the repository at this point in the history

  62. Display progress while looping through clients

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    a4af05d View commit details
    Browse the repository at this point in the history

  63. glob?

    Andrew Zito committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    2436e43 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2022

  1. 8 parallel jobs!?!?!? MADNESS

    Andrew Zito committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    9ba909f View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2022

  1. wait for assets to be compiled when deploying

    Andrew Zito committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    25cb5d3 View commit details
    Browse the repository at this point in the history

  2. bump assethash

    Andrew Zito committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    7ca8437 View commit details
    Browse the repository at this point in the history

  3. deploy waits for assets to be compiled

    Andrew Zito committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    423f943 View commit details
    Browse the repository at this point in the history

  4. gha actions exception go to a different slack channel (maybe)

    Andrew Zito committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    04851b4 View commit details
    Browse the repository at this point in the history

  5. bump asset checksum

    Andrew Zito committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    51513da View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2022

  1. try overriding slack channel

    Andrew Zito committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    b7fc3ec View commit details
    Browse the repository at this point in the history

  2. bump asset checksum

    Andrew Zito committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    dadcc69 View commit details
    Browse the repository at this point in the history

  3. syntax

    Andrew Zito committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    bf6a49e View commit details
    Browse the repository at this point in the history

  4. revert require => import

    Andrew Zito committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    d568cad View commit details
    Browse the repository at this point in the history

  5. Better log tailing?

    Andrew Zito committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    e53f22e View commit details
    Browse the repository at this point in the history

  6. Merge branch 'release-33' into andy/deployment-stuff

    Andrew Zito committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    5b3cef0 View commit details
    Browse the repository at this point in the history

  7. various cleanup

    Andrew Zito committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    07d99ef View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2022

  1. Merge remote-tracking branch 'origin/release-33' into andy/deployment… 

    …-stuff
    Andrew Zito committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    a811b49 View commit details
    Browse the repository at this point in the history

  2. Now that frequent dev is done, restore other github workflows

    Andrew Zito committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    54b6cae View commit details
    Browse the repository at this point in the history

  3. Update .github/workflows/asset_compilation.yml 

    Co-authored-by: Elliot <elliot@greenriver.org>
    @andyzito @eanders
    andyzito and eanders committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    bdc67b1 View commit details
    Browse the repository at this point in the history

  4. Update .github/workflows/asset_compilation.yml 

    Co-authored-by: Elliot <elliot@greenriver.org>
    @andyzito @eanders
    andyzito and eanders committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    f8abf12 View commit details
    Browse the repository at this point in the history

  5. Rename load groups

    Andrew Zito committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    aacb9f0 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/andy/deployment-stuff' into andy… 

    …/deployment-stuff
    Andrew Zito committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    2e8dc83 View commit details
    Browse the repository at this point in the history

  7. fix command injection warnings from brakeman?

    Andrew Zito committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    358961b View commit details
    Browse the repository at this point in the history

  8. forgot self.class...

    Andrew Zito committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    45d56a9 View commit details
    Browse the repository at this point in the history

  9. hm, File.sanitize is a rubyworks (3d party) thing... we probably don'… 

    …t need it now that we've got other sanitization?
    Andrew Zito committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    ffe4ac3 View commit details
    Browse the repository at this point in the history

  10. try matrix ecr build for fun

    Andrew Zito committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    67aebdb View commit details
    Browse the repository at this point in the history

  11. workflow syntax

    Andrew Zito committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    96a612f View commit details
    Browse the repository at this point in the history

  12. aaaaand those're the wrong variants

    Andrew Zito committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    72a6647 View commit details
    Browse the repository at this point in the history

  13. bash syntax?

    Andrew Zito committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    72a0f09 View commit details
    Browse the repository at this point in the history

  14. well, looks like matrix ecr will take a bit more work. but I still wa… 

    …nt to trigger a full asset rebuild.
    Andrew Zito committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    0973004 View commit details
    Browse the repository at this point in the history

  15. Fix some sanitization in deployer.rb

    Andrew Zito committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    dc07637 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2022

  1. Merge branch 'release-33' into andy/deployment-stuff

    @eanders
    eanders committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    073dc08 View commit details
    Browse the repository at this point in the history