-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compatibility to new sp/rgdal #17
Comments
This is now urgent, as sp is being released and breaks BIRDS |
Hi Roger, |
Current master seens to complete CMD check with two NOTEs, with sp 1.4-4 and rgdal 1.5-17 and PROJ 7.1.1 and GDAL 3.1.3. This is better than released BIRDS: 2 ERRORs, 1 WARNING, 2 NOTEs. I do not know what you mean by "backwards compatibility"; if you need to support users with old scripts or old stored objects, you'll need to condition on sp and rgdal versions, and possibly on PROJ/GDAL versions. No packages depend on or import from BIRDS, so I'm unsure whether there are any reasons to do anything other than alert users to any user-visible changes to the only published version of your package. |
In reverse dependency checks, there appear to be more problems with current sp from github - rsbivand/sp and R-Forge rgdal. The underlying problem seems to stem from CRS(proj4string(x)), testing that proj4string() values are equal, and so on. Be aware that proj4string() values are retained only for out-of-date PROJ/GDAL versions, and that other mechanisms are used replacing the use of Proj4 strings with WKT2_2019 strings for PROJ >= 6 and GDAL >= 3 (already in the CRAN Windows binaries of sf and rgdal). You also use constructions like
points@proj4string
which should always be slot(points, "proj4string"). This is certainly not resolved. There are multiple errors when running soon to be released sp/rgdal with current PROJ/GDAL both on released BIRDS, and possibly more problems with BIRDS master.Originally posted by @rsbivand in #9 (comment)
The text was updated successfully, but these errors were encountered: